refactor(topnav): update top navigation component specs #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for helix-ui ready! Built with commit 54c1851 |
100stacks
requested changes
Dec 17, 2020
There was a problem hiding this comment.
@danielmdesigns please see Top Navigation updates based on current specs:
https://deploy-preview-807--helix-ui.netlify.app/components/topnav
danielmdesigns
suggested changes
Dec 17, 2020
There was a problem hiding this comment.
Here is some initial feedback:
- Dropshadow for dropdowns are too dark. I would suggest reducing the opacity/alpha transparency there. Selecting this object in Abstract will give you the box-shadow specs that we used in our design
- Nav links should not be in all caps
- Default link colors are wrong. We should use #757575 for all Top & Bottom nav links
- Remove background color from hover. Hover/Selected state link color will be #333333
- Default Icon color should be #9E9E9E (hover/selected icons will be #333333)
- Dropdown links should not have a background on hover. The Default link color will be #333333 with a Hover/Selected color of #970C8D
- Button hover state color is wrong. Button states should be Blue-500 Default, Blue-700 Hover, Blue-900 Selected
- Button should not have border-color on hover
The Navigation link in Abstract has been updated. Please reference this to support the feedback provided above. If you have any other questions, please do not hesitate to ask.
100stacks
changed the title
|
@danielmdesigns : Please review the changes based on your feedback. |
danielmdesigns
suggested changes
Dec 21, 2020
100stacks
requested changes
Dec 21, 2020
100stacks
added
PR: Comments Provided
100stacks
approved these changes
Dec 22, 2020
There was a problem hiding this comment.
Dev LGTM...great job @lalithkarikelli!
@danielmdesigns, we're going to update the icons in a future release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<hx-topnav>implementing color palette 2.0 stylesWhat are the relevant story cards/tickets? Any additional PRs or other references?
Jira: SURF 2142
Before you request a review for this PR:
yarn testto ensure all tests passed?