Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(v1.x): HelixUI-v1.x documentation #800

Merged
merged 1 commit into from
Dec 10, 2020
Merged

feat(v1.x): HelixUI-v1.x documentation #800

merged 1 commit into from
Dec 10, 2020

Conversation

100stacks
Copy link
Member

@100stacks 100stacks commented Dec 9, 2020 •
edited
Loading

Description

In preparation for major updates, moving legacy HelixUI-v1.x documentation.

What are the relevant story cards/tickets? Any additional PRs or other references?

Jira: SURF-2141

Before you request a review for this PR:

  • For UI changes, did you manually test in recent versions of modern browsers (Chrome, Firefox, and Safari)?
  • For UI changes, did you manually test in IE11 and legacy Edge?
  • Did you add component tests for any new code?
  • Did you run the component unit tests via yarn test to ensure all tests passed?
  • Did you include a screenshot of the component tests?
  • If you changed/added functionality, did you update the demo page and documentation?
  • If needed, did you add or modify the demo test page to test the changed/added functionality?
  • Did you assign reviewers?
  • In Jira, have you linked to this PR on the ticket(s)?

@100stacks 100stacks added this to the HelixUI-v2.0.0 milestone Dec 9, 2020
@netlify
Copy link

netlify bot commented Dec 9, 2020 •
edited
Loading

Deploy preview for helix-ui ready!

Built with commit 493b88b

https://deploy-preview-800--helix-ui.netlify.app

@100stacks 100stacks added the 🆕 FEATURE New HelixUI feature or addition label Dec 9, 2020
lalithkarikelli
lalithkarikelli approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@lalithkarikelli lalithkarikelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEV LGTM

badejayayesubabu
badejayayesubabu approved these changes Dec 10, 2020
View reviewed changes
Copy link
Collaborator

@badejayayesubabu badejayayesubabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEV LGTM

@100stacks 100stacks force-pushed the HelixUI-v1.x-documentation branch 3 times, most recently from a89db59 to 1682391 Compare December 10, 2020 16:55
@100stacks 100stacks force-pushed the HelixUI-v1.x-documentation branch from 1682391 to 493b88b Compare December 10, 2020 17:11
@100stacks 100stacks merged commit 7932322 into master Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalithkarikelli lalithkarikelli lalithkarikelli approved these changes

@badejayayesubabu badejayayesubabu badejayayesubabu approved these changes

Assignees
No one assigned
Labels
📝 Documentation 🆕 FEATURE New HelixUI feature or addition
Projects
None yet
Milestone
HelixUI-v2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@100stacks @lalithkarikelli @badejayayesubabu