docs(dropdown): implement and document attrs and vars #799

lalithkarikelli · 2020-12-09T14:24:37Z

Description

hx-dropdownSelect : Implement and document attributes and variables

What are the relevant story cards/tickets? Any additional PRs or other references?

Jira: SURF 2105

Before you request a review for this PR:

For UI changes, did you manually test in recent versions of modern browsers (Chrome, Firefox, and Safari)?
For UI changes, did you manually test in IE11 and legacy Edge?
Did you add component tests for any new code?
Did you run the component unit tests via yarn test to ensure all tests passed?
Did you include a screenshot of the component tests?
If you changed/added functionality, did you update the demo page and documentation?
If needed, did you add or modify the demo test page to test the changed/added functionality?
Did you assign reviewers?
In Jira, have you linked to this PR on the ticket(s)?

netlify · 2020-12-09T14:24:41Z

Deploy preview for helix-ui ready!

Built with commit 07f9bed

https://deploy-preview-799--helix-ui.netlify.app

badejayayesubabu · 2020-12-14T07:35:01Z

src/scss/components/dropdown-select/mixins/SelectControl.scss

-    background-color: $gray-0;
-    color: $gray-900;
+  } @else {
+    background-color: var(--hxDropdown-unfocused-backgroundColor, $gray-0);


please change to var(--hxDropdown-unfocused-bgcolor, $gray-0);

Changes have been done, please review.

I'm not seeing the recommended variable name change, please double check.

badejayayesubabu · 2020-12-14T07:35:53Z

src/scss/components/dropdown-select/mixins/SelectControl.scss

-    background-color: $gray-0;
-    color: $gray-900;
+  } @else {
+    background-color: var(--hxDropdown-unfocused-invalid-backgroundColor, $gray-0);


please change to var(--hxDropdown-unfocused-invalid-bgcolor, $gray-0);

Changes have been done, please review.

I'm not seeing the recommended variable name change, please double check.

badejayayesubabu · 2020-12-14T07:37:19Z

src/scss/components/dropdown-select/mixins/SelectControl.scss

-    background-color: $gray-100;
-    color: $gray-700;
+  } @else {
+    background-color: var(--hxDropdown-unfocused-disabled-backgroundColor, $gray-100);


please change to var(--hxDropdown-unfocused-disabled-bgcolor, $gray-100);

Changes have been done, please review.

I'm not seeing the recommended variable name change, please double check.

badejayayesubabu · 2020-12-14T09:20:52Z

src/scss/components/dropdown-select/mixins/SelectFacade.scss

@@ -7,7 +7,7 @@
  }
  @else {
    border: 1px solid $gray-500;


please change to border: 1px solid var(--hxDropdown-border, $gray-500);

Changes have been done, please review.

badejayayesubabu · 2020-12-14T09:22:24Z

src/scss/components/dropdown-select/mixins/SelectFacade.scss

@@ -18,7 +18,7 @@
  }
  @else {
    border: 2px solid $red-900;


please follow same pattern through out the application
change to border: 2px solid var(--hxDropdown-invalid-border, $gray-900);

Changes have been done, please review.

badejayayesubabu

DEV LGTM

100stacks

@lalithkarikelli, please squash commits.

lalithkarikelli · 2021-01-05T09:42:48Z

@lalithkarikelli, please squash commits.

@100stacks rebased and squashed the commits

100stacks

Please rebase.

lalithkarikelli · 2021-01-20T11:40:23Z

Please rebase.

done.

100stacks · 2021-02-02T22:56:45Z

src/scss/components/dropdown-select/mixins/SelectControl.scss

-    background-color: $gray-0;
-    color: $gray-900;
+  } @else {
+    background-color: var(--hxDropdown-unfocused-backgroundColor, $gray-0);


I'm not seeing the recommended variable name change, please double check.

100stacks · 2021-02-02T22:57:12Z

src/scss/components/dropdown-select/mixins/SelectControl.scss

-    background-color: $gray-0;
-    color: $gray-900;
+  } @else {
+    background-color: var(--hxDropdown-unfocused-invalid-backgroundColor, $gray-0);


I'm not seeing the recommended variable name change, please double check.

100stacks · 2021-02-02T22:57:35Z

src/scss/components/dropdown-select/mixins/SelectControl.scss

-    background-color: $gray-100;
-    color: $gray-700;
+  } @else {
+    background-color: var(--hxDropdown-unfocused-disabled-backgroundColor, $gray-100);


I'm not seeing the recommended variable name change, please double check.

100stacks · 2021-02-02T22:58:40Z

src/scss/components/dropdown-select/mixins/SelectFacade.scss

@@ -2,40 +2,36 @@

 @mixin __selectFacade($focused: false) {
  @if $focused {
-    border: 1px solid $cyan-700;
+    border: 1px solid var(--hxDropdown-focused-borderColor, $cyan-700);


Please update to the new Color Palette 2.0 color variables.

Changes have been done, please review.

100stacks · 2021-02-02T22:58:53Z

src/scss/components/dropdown-select/mixins/SelectFacade.scss

  }
 }

 @mixin __selectFacade--invalid($focused: false) {
  @if $focused {
-    border: 2px solid $red-900;
+    border: 2px solid var(--hxDropdown-invalid-focused-borderColor, $red-900);


Please update to the new Color Palette 2.0 color variables.

Changes have been done, please review.

100stacks · 2021-02-02T22:59:01Z

src/scss/components/dropdown-select/mixins/SelectFacade.scss

-    border: 2px solid $red-900;
-    color: $gray-900;
+  } @else {
+    border: 2px solid var(--hxDropdown-invalid-unfocused-borderColor, $red-900);


Please update to the new Color Palette 2.0 color variables.

Changes have been done, please review.

100stacks

Dev LGTM

100stacks added 📝 Documentation CSS labels Dec 9, 2020

100stacks added this to the HelixUI-v2.0.0 milestone Dec 9, 2020

100stacks requested review from badejayayesubabu and 100stacks December 9, 2020 15:49

badejayayesubabu reviewed Dec 14, 2020

View reviewed changes

lalithkarikelli marked this pull request as ready for review December 15, 2020 10:39

badejayayesubabu approved these changes Dec 16, 2020

View reviewed changes

100stacks changed the title ~~docs(hx-dropdownSelect): implement and document attribute and variables~~ docs(dropdown): implement and document attrs and vars Dec 17, 2020

100stacks marked this pull request as draft December 21, 2020 20:23

100stacks requested changes Dec 23, 2020

View reviewed changes

100stacks added the PR: Comments Provided PR: Comments Provided label Dec 23, 2020

100stacks removed the PR: Comments Provided PR: Comments Provided label Jan 13, 2021

100stacks modified the milestones: HelixUI-v2.0.0, HelixUI-v2.x Jan 13, 2021

lalithkarikelli marked this pull request as ready for review January 13, 2021 11:57

100stacks modified the milestones: HelixUI-v2.x, HelixUI-v2.1.0 Jan 19, 2021

100stacks requested changes Jan 19, 2021

View reviewed changes

100stacks added PR: Comments Provided PR: Comments Provided PR: Needs Rebase labels Jan 19, 2021

lalithkarikelli requested a review from 100stacks January 21, 2021 07:45

100stacks removed PR: Comments Provided PR: Comments Provided PR: Needs Rebase labels Feb 2, 2021

100stacks requested changes Feb 2, 2021

View reviewed changes

100stacks added the PR: Comments Provided PR: Comments Provided label Feb 2, 2021

lalithkarikelli requested a review from 100stacks February 3, 2021 13:19

docs(hx-dropdownSelect): implement and document attribute and variables

07f9bed

100stacks approved these changes Feb 3, 2021

View reviewed changes

100stacks removed the PR: Comments Provided PR: Comments Provided label Feb 3, 2021

100stacks merged commit 6d9dee8 into HelixDesignSystem:master Feb 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs(dropdown): implement and document attrs and vars #799

docs(dropdown): implement and document attrs and vars #799

lalithkarikelli commented Dec 9, 2020 •

edited

Loading

netlify bot commented Dec 9, 2020 •

edited

Loading

badejayayesubabu Dec 14, 2020

lalithkarikelli Dec 15, 2020

100stacks Feb 2, 2021

badejayayesubabu Dec 14, 2020

lalithkarikelli Dec 15, 2020

100stacks Feb 2, 2021

badejayayesubabu Dec 14, 2020 •

edited

Loading

lalithkarikelli Dec 15, 2020

100stacks Feb 2, 2021

badejayayesubabu Dec 14, 2020

lalithkarikelli Dec 15, 2020

badejayayesubabu Dec 14, 2020

lalithkarikelli Dec 15, 2020

badejayayesubabu left a comment

100stacks left a comment

lalithkarikelli commented Jan 5, 2021

100stacks left a comment

lalithkarikelli commented Jan 20, 2021

Please rebase.

100stacks Feb 2, 2021

100stacks Feb 2, 2021

100stacks Feb 2, 2021

100stacks Feb 2, 2021

lalithkarikelli Feb 3, 2021

100stacks Feb 2, 2021

lalithkarikelli Feb 3, 2021

100stacks Feb 2, 2021

lalithkarikelli Feb 3, 2021

100stacks left a comment

docs(dropdown): implement and document attrs and vars #799

docs(dropdown): implement and document attrs and vars #799

Conversation

lalithkarikelli commented Dec 9, 2020 • edited Loading

Description

What are the relevant story cards/tickets? Any additional PRs or other references?

Before you request a review for this PR:

netlify bot commented Dec 9, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

badejayayesubabu Dec 14, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

badejayayesubabu left a comment

Choose a reason for hiding this comment

100stacks left a comment

Choose a reason for hiding this comment

lalithkarikelli commented Jan 5, 2021

100stacks left a comment

Choose a reason for hiding this comment

Please rebase.

lalithkarikelli commented Jan 20, 2021

Please rebase.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

100stacks left a comment

Choose a reason for hiding this comment

lalithkarikelli commented Dec 9, 2020 •

edited

Loading

netlify bot commented Dec 9, 2020 •

edited

Loading

badejayayesubabu Dec 14, 2020 •

edited

Loading