Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(checkbox): implement and document vars and attrs #798

Merged
merged 1 commit into from
Jan 27, 2021
Merged

docs(checkbox): implement and document vars and attrs #798

merged 1 commit into from
Jan 27, 2021

Conversation

badejayayesubabu
Copy link
Collaborator

@badejayayesubabu badejayayesubabu commented Dec 9, 2020 •
edited
Loading

Description

hx-checkbox : implement and document variables and attributes

What are the relevant story cards/tickets? Any additional PRs or other references?

Jira: SURF-2102

Before you request a review for this PR:

  • For UI changes, did you manually test in recent versions of modern browsers (Chrome, Firefox, and Safari)?
  • For UI changes, did you manually test in IE11 and legacy Edge?
  • Did you add component tests for any new code?
  • Did you run the component unit tests via yarn test to ensure all tests passed?
  • Did you include a screenshot of the component tests?
  • If you changed/added functionality, did you update the demo page and documentation?
  • If needed, did you add or modify the demo test page to test the changed/added functionality?
  • Did you assign reviewers?
  • In Jira, have you linked to this PR on the ticket(s)?

@netlify
Copy link

netlify bot commented Dec 9, 2020 •
edited
Loading

Deploy preview for helix-ui ready!

Built with commit fe93c05

https://deploy-preview-798--helix-ui.netlify.app

@100stacks 100stacks added this to the HelixUI-v2.0.0 milestone Dec 9, 2020
lalithkarikelli
lalithkarikelli suggested changes Dec 10, 2020
View reviewed changes
src/scss/components/checkbox/_index.scss Outdated
@@ -120,11 +120,11 @@ hx-checkbox-control {

&:checked,
&:indeterminate {
color: $cyan-900;
color: var(--hxCheckbox-indeterminate, $cyan-900);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change to var(--hxCheckbox-indeterminate-color, $cyan-900);

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes have been done, Please review

src/scss/components/checkbox/_index.scss Outdated
border-color: $cyan-900;
color: $cyan-900;
border-color: var(--hxCheckbox-indeterminate-label-bordercolor, $cyan-900);
color: var(--hxCheckbox-indeterminate-label, $cyan-900);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change to var(--hxCheckbox-indeterminate-label-color, $cyan-900);

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes have been done, Please review

src/scss/components/checkbox/_index.scss Outdated
@@ -179,7 +179,7 @@ hx-checkbox-control > input[type="checkbox"]:disabled {
}

~ label {
color: $gray-700;
color: var(--hxCheckbox-disabled-label, $gray-700);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change to var(--hxCheckbox-disabled-label-color, $gray-700);

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes have been done, Please review

src/scss/components/checkbox/mixins/_hxCheckboxControl.scss Outdated
@@ -8,22 +8,22 @@
box-shadow: $focus-glow;

&::-ms-check {
border-color: $cyan-700;
border-color: var(--hxCheckbox-bordercolor-focus, $cyan-700);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please follow same pattern through out the application .

change it to var(--hxCheckbox-focus-bordercolor, $cyan-700);

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes have been done, Please review

@badejayayesubabu badejayayesubabu force-pushed the SURF-2102 branch 3 times, most recently from 1dcf27e to 58285d3 Compare December 16, 2020 09:33
@100stacks 100stacks changed the title docs(hx-checkbox): implement and document variables and attributes docs(checkbox): implement and document vars and attrs Dec 17, 2020
@100stacks 100stacks marked this pull request as ready for review December 23, 2020 17:26
100stacks
100stacks requested changes Dec 23, 2020
View reviewed changes
Copy link
Member

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BY00565233, please rebase and fix merge conflicts.

100stacks
100stacks requested changes Jan 19, 2021
View reviewed changes
Copy link
Member

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase.

lalithkarikelli
lalithkarikelli approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@lalithkarikelli lalithkarikelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEV LGTM

100stacks
100stacks approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev LGTM

@100stacks 100stacks merged commit 5d3969f into HelixDesignSystem:master Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@100stacks 100stacks 100stacks approved these changes

@lalithkarikelli lalithkarikelli lalithkarikelli approved these changes

Assignees
No one assigned
Labels
CSS 📝 Documentation
Projects
None yet
Milestone
HelixUI-v2.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@badejayayesubabu @100stacks @lalithkarikelli