Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(styles): update typography and colors #797

Merged
merged 1 commit into from
Dec 10, 2020
Merged

feat(styles): update typography and colors #797

merged 1 commit into from
Dec 10, 2020

Conversation

100stacks
Copy link
Member

@100stacks 100stacks commented Dec 9, 2020 •
edited
Loading

Description

Update styles - typography and colors.

What are the relevant story cards/tickets? Any additional PRs or other references?

Jira: SURF-2138

Before you request a review for this PR:

  • For UI changes, did you manually test in recent versions of modern browsers (Chrome, Firefox, and Safari)?
  • For UI changes, did you manually test in IE11 and legacy Edge?
  • Did you add component tests for any new code?
  • Did you run the component unit tests via yarn test to ensure all tests passed?
  • Did you include a screenshot of the component tests?
  • If you changed/added functionality, did you update the demo page and documentation?
  • If needed, did you add or modify the demo test page to test the changed/added functionality?
  • Did you assign reviewers?
  • In Jira, have you linked to this PR on the ticket(s)?

@100stacks 100stacks added this to the HelixUI-v2.0.0 milestone Dec 9, 2020
@netlify
Copy link

netlify bot commented Dec 9, 2020 •
edited
Loading

Deploy preview for helix-ui ready!

Built with commit f1bcbf4

https://deploy-preview-797--helix-ui.netlify.app

lalithkarikelli
lalithkarikelli approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@lalithkarikelli lalithkarikelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEV LGTM

badejayayesubabu
badejayayesubabu approved these changes Dec 9, 2020
View reviewed changes
Copy link
Collaborator

@badejayayesubabu badejayayesubabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEV LGTM

100stacks
100stacks commented Dec 9, 2020
View reviewed changes
Copy link
Member Author

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielmdesigns this PR includes typography and color updates. Please see:

https://deploy-preview-797--helix-ui.netlify.app/components/typography

@100stacks 100stacks added the PR: Needs Design Review PR: Needs Design Review label Dec 9, 2020
danielmdesigns
danielmdesigns suggested changes Dec 9, 2020
View reviewed changes
Copy link

@danielmdesigns danielmdesigns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like base styles and colors need to be updated per our design specs. we have updated typography sepcs coming later today and we should align to those updates.

@100stacks 100stacks force-pushed the surf-2138-design-updates-rev0 branch 2 times, most recently from c695c51 to 2a18b07 Compare December 9, 2020 19:37
100stacks
100stacks commented Dec 9, 2020
View reviewed changes
Copy link
Member Author

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like base styles and colors need to be updated per our design specs. we have updated typography sepcs coming later today and we should align to those updates.

Updated heading styles.

@100stacks 100stacks force-pushed the surf-2138-design-updates-rev0 branch from 2a18b07 to 8b0aa8e Compare December 9, 2020 21:57
@100stacks 100stacks force-pushed the surf-2138-design-updates-rev0 branch from 8b0aa8e to f1bcbf4 Compare December 10, 2020 19:23
100stacks
100stacks commented Dec 10, 2020
View reviewed changes
Copy link
Member Author

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielmdesigns, I'm going to merge this PR #797 and we'll iterate on updates.

@100stacks 100stacks merged commit 56b7edf into master Dec 10, 2020
@100stacks 100stacks removed the PR: Needs Design Review PR: Needs Design Review label Dec 10, 2020
@100stacks 100stacks deleted the surf-2138-design-updates-rev0 branch December 10, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmdesigns danielmdesigns danielmdesigns requested changes

@lalithkarikelli lalithkarikelli lalithkarikelli approved these changes

@badejayayesubabu badejayayesubabu badejayayesubabu approved these changes

Assignees
No one assigned
Labels
🆕 🚧 BETA FEATURE
Projects
None yet
Milestone
HelixUI-v2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@100stacks @danielmdesigns @lalithkarikelli @badejayayesubabu