docs(choice-tile): implement and document vars and attrs #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for helix-ui ready! Built with commit 43e273c |
| @@ -27,24 +25,22 @@ | |||
| @mixin hxChoiceTile--invalid($pseudo-state: null) { | |||
| @if $pseudo-state == focus { | |||
| box-shadow: $focus-glow-invalid; | |||
| } | |||
| @else if $pseudo-state == hover { | |||
| } @else if $pseudo-state == hover { | |||
| background-color: $red-100; | |||
There was a problem hiding this comment.
Please write : background-color: var(--hxChoiceTile-invalid-hover-bgcolor, $red-100);
There was a problem hiding this comment.
Changes have been done, please review.
| @@ -27,24 +25,22 @@ | |||
| @mixin hxChoiceTile--invalid($pseudo-state: null) { | |||
| @if $pseudo-state == focus { | |||
| box-shadow: $focus-glow-invalid; | |||
| } | |||
| @else if $pseudo-state == hover { | |||
| } @else if $pseudo-state == hover { | |||
| background-color: $red-100; | |||
| border-color: $red-900; | |||
There was a problem hiding this comment.
Please write : border-color : var(--hxChoiceTile-invalid-hover-bordercolor, $red-900);
There was a problem hiding this comment.
Changes have been done, please review.
100stacks
changed the title
100stacks
requested changes
Jan 19, 2021
@100stacks fixed merge conflicts ,rebased with master, added new variables and squashed the commits |
100stacks
approved these changes
Feb 2, 2021
There was a problem hiding this comment.
@lalithkarikelli, we'll work on small mods to variable naming at a future time.
Dev LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
hx-choicetile: implement and document variables and attributesWhat are the relevant story cards/tickets? Any additional PRs or other references?
Jira: SURF 2103
Before you request a review for this PR:
yarn testto ensure all tests passed?