docs(drawer): implement and document attrs and vars #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for helix-ui ready! Built with commit a2d2ca4 |
100stacks
requested changes
Dec 15, 2020
| @@ -39,7 +39,7 @@ hx-drawer { | |||
| } | |||
|
|
|||
| > hx-div { | |||
| background-color: $gray-0; | |||
| background-color: var(--hxDrawer-hxDiv-bgcolor, $gray-0); | |||
| border-top: 1px solid $gray-400; | |||
There was a problem hiding this comment.
Please change to:
border-top: 1px solid var(--hxDrawer-hxdiv-border-top, $gray-400);There was a problem hiding this comment.
Changes have been done, please review.
| @@ -48,7 +48,7 @@ hx-drawer { | |||
| } | |||
|
|
|||
| > footer { | |||
| background-color: $gray-0; | |||
| background-color: var(--hxDrawer-footer-bgcolor, $gray-0); | |||
| border-top: 1px solid $gray-400; | |||
There was a problem hiding this comment.
Please change to:
border-top: 1px solid var(--hxDrawer-footer-border-top, $gray-400);There was a problem hiding this comment.
Changes have been done, please review.
| @@ -39,7 +39,7 @@ hx-drawer { | |||
| } | |||
|
|
|||
| > hx-div { | |||
| background-color: $gray-0; | |||
| background-color: var(--hxDrawer-hxDiv-bgcolor, $gray-0); | |||
There was a problem hiding this comment.
Please change to:
background-color: var(--hxDrawer-hxdiv-bgcolor, $gray-0);There was a problem hiding this comment.
Changes have been done, please review.
100stacks
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
hx-drawer: Implement and document attributes and variablesWhat are the relevant story cards/tickets? Any additional PRs or other references?
Jira: SURF 2104
Before you request a review for this PR:
yarn testto ensure all tests passed?