refactor(hx-alert): implement custom variables #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for helix-ui ready! Built with commit 35d6b2a |
100stacks
requested changes
Nov 30, 2020
src/scss/components/alert/index.scss
Outdated
| display: block; | ||
| font-weight: 300; | ||
| line-height: 1.25rem; | ||
|
|
||
| &[type="info"] { | ||
| background-color: $blue-100; | ||
| color: $gray-1000; | ||
| background-color: var(--hxBlue, $blue-100); |
There was a problem hiding this comment.
All CSS variables should be scoped to hxAlert:
background-color: var(--hxAlert-info-bgcolor, $blue-100);
src/scss/components/alert/index.scss
Outdated
| background-color: $blue-100; | ||
| color: $gray-1000; | ||
| background-color: var(--hxBlue, $blue-100); | ||
| color: var(--hxColor, $gray-1000); |
There was a problem hiding this comment.
All CSS variables should be scoped to hxAlert:
color: var(--hxAlert-info-color, $gray-1000);There was a problem hiding this comment.
Changes have been done,Please review
src/scss/components/alert/index.scss
Outdated
| } | ||
|
|
||
| &[type="error"] { | ||
| background-color: $red-900; | ||
| color: $gray-0; | ||
| background-color: var(--hxRed, $red-900); |
There was a problem hiding this comment.
Please see above examples to update changes here and below.
There was a problem hiding this comment.
Changes have been done,Please review
badejayayesubabu
force-pushed
the
SURF-2095
branch
from
fb5f2ed to
594629c
Compare
badejayayesubabu
force-pushed
the
SURF-2095
branch
from
3d33f0d to
85f2378
Compare
badejayayesubabu
force-pushed
the
SURF-2095
branch
from
85f2378 to
35d6b2a
Compare
100stacks
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Converted Custom variables
What are the relevant story cards/tickets? Any additional PRs or other references?
Jira: SURF-2095
Before you request a review for this PR:
yarn testto ensure all tests passed?