Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(secnav): implement secondary navigation component #773

Merged
merged 1 commit into from
Oct 28, 2020
Merged

feat(secnav): implement secondary navigation component #773

merged 1 commit into from
Oct 28, 2020

Conversation

lalithkarikelli
Copy link
Contributor

@lalithkarikelli lalithkarikelli commented Oct 14, 2020 •
edited by 100stacks
Loading

Description

Implement Sec Nav (Secondary Navigation).

What are the relevant story cards/tickets? Any additional PRs or other references?

Jira: SURF1766

Before you request a review for this PR:

  • For UI changes, did you manually test in recent versions of modern browsers (Chrome, Firefox, and Safari)?
  • For UI changes, did you manually test in IE11 and legacy Edge?
  • Did you add component tests for any new code?
  • Did you run the component unit tests via yarn test to ensure all tests passed?
  • Did you include a screenshot of the component tests?
  • If you changed/added functionality, did you update the demo page and documentation?
  • If needed, did you add or modify the demo test page to test the changed/added functionality?
  • Did you assign reviewers?
  • In Jira, have you linked to this PR on the ticket(s)?

@netlify
Copy link

netlify bot commented Oct 14, 2020 •
edited
Loading

Deploy preview for helix-ui ready!

Built with commit f1e421f

https://deploy-preview-773--helix-ui.netlify.app

@lalithkarikelli lalithkarikelli marked this pull request as ready for review October 14, 2020 11:54
@100stacks 100stacks added this to the HelixUI-v1.1.0 milestone Oct 14, 2020
@100stacks 100stacks added the 🚧 WIP Work in Progress label Oct 14, 2020
@100stacks 100stacks marked this pull request as draft October 14, 2020 18:48
100stacks
100stacks requested changes Oct 14, 2020
View reviewed changes
@100stacks 100stacks changed the title refactor(hx-secnav): New Component Secondary Navigation feat(secnav): implement secondary navigation component Oct 14, 2020
@lalithkarikelli lalithkarikelli marked this pull request as ready for review October 19, 2020 06:48
badejayayesubabu
badejayayesubabu approved these changes Oct 19, 2020
View reviewed changes
Copy link
Collaborator

@badejayayesubabu badejayayesubabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev LGTM

@100stacks 100stacks removed the 🚧 WIP Work in Progress label Oct 19, 2020
100stacks
100stacks requested changes Oct 20, 2020
View reviewed changes
100stacks
100stacks requested changes Oct 27, 2020
View reviewed changes
100stacks
100stacks approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Dev LGTM

@100stacks 100stacks added the Hacktoberfest-Accepted Hacktoberfest 2020 Accepted PR label Oct 28, 2020
@100stacks 100stacks merged commit 30a9ef1 into HelixDesignSystem:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@100stacks 100stacks 100stacks approved these changes

@badejayayesubabu badejayayesubabu badejayayesubabu approved these changes

Assignees
No one assigned
Labels
CSS Hacktoberfest-Accepted Hacktoberfest 2020 Accepted PR 🆕 🎉 HelixUI Component New HelixUI Component
Projects
None yet
Milestone
HelixUI-v1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lalithkarikelli @100stacks @badejayayesubabu