Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hx-text-control): add help and error text #768

Merged
merged 1 commit into from
Oct 8, 2020
Merged

feat(hx-text-control): add help and error text #768

merged 1 commit into from
Oct 8, 2020

Conversation

badejayayesubabu
Copy link
Collaborator

@badejayayesubabu badejayayesubabu commented Sep 29, 2020 •
edited
Loading

Description

Add Help Text and Error Text to hx-text-control

Jira: SURF-2065

Before you request a review for this PR:

  • For UI changes, did you manually test in recent versions of modern browsers (Chrome, Firefox, and Safari)?
  • For UI changes, did you manually test in IE11 and legacy Edge
  • Did you assign reviewers?
  • In Jira, have you linked to this PR on the ticket(s)?

@netlify
Copy link

netlify bot commented Sep 29, 2020 •
edited
Loading

Deploy preview for helix-ui ready!

Built with commit 2546604

https://deploy-preview-768--helix-ui.netlify.app

@100stacks 100stacks added the CSS label Sep 29, 2020
@100stacks 100stacks added this to the HelixUI-v1.1.0 milestone Sep 29, 2020
lalithkarikelli
lalithkarikelli approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@lalithkarikelli lalithkarikelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEV LGTM

100stacks
100stacks requested changes Oct 1, 2020
View reviewed changes
Copy link
Member

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BY00565233 did you validate this change in all five browsers that we support?

@100stacks 100stacks added the PR: Comments Provided PR: Comments Provided label Oct 1, 2020
@100stacks 100stacks marked this pull request as ready for review October 1, 2020 22:10
@badejayayesubabu
Copy link
Collaborator Author

@BY00565233 did you validate this change in all five browsers that we support?

@100stacks 100stacks reopened this Oct 5, 2020
@100stacks 100stacks removed the PR: Comments Provided PR: Comments Provided label Oct 7, 2020
@100stacks 100stacks changed the title refactor(hx-text-control): added help and error text feat(hx-text-control): add help and error text Oct 8, 2020
@100stacks 100stacks merged commit 9c82fc9 into HelixDesignSystem:master Oct 8, 2020
@100stacks 100stacks added the Hacktoberfest-Accepted Hacktoberfest 2020 Accepted PR label Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@100stacks 100stacks 100stacks approved these changes

@lalithkarikelli lalithkarikelli lalithkarikelli approved these changes

Assignees
No one assigned
Labels
CSS Hacktoberfest-Accepted Hacktoberfest 2020 Accepted PR
Projects
None yet
Milestone
HelixUI-v1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@badejayayesubabu @100stacks @lalithkarikelli