Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(hx-tabset): add dynamic tab with id on render #745

Merged
merged 1 commit into from
Aug 10, 2020

Conversation

100stacks
Copy link
Member

@100stacks 100stacks commented Aug 3, 2020

Description

screenshot: <hx-tabset> dynamic tabs with id test

Skipped Test

Screen Shot 2020-08-03 at 4 28 07 PM

Failing Test

Screen Shot 2020-08-03 at 4 28 59 PM

Screen Shot 2020-08-03 at 4 28 43 PM

What are the relevant story cards/tickets? Any additional PRs or other references?

Jira: SURF-2070

Before you request a review for this PR:

  • For UI changes, did you manually test in recent versions of modern browsers (Chrome, Firefox, and Safari)?
  • For UI changes, did you manually test in IE11 and legacy Edge?
  • Did you add component tests for any new code?
  • Did you run the component unit tests via yarn test to ensure all tests passed?
  • Did you include a screenshot of the component tests?
  • If you changed/added functionality, did you update the demo page and documentation?
  • If needed, did you add or modify the demo test page to test the changed/added functionality?
  • Did you assign reviewers?
  • In Jira, have you linked to this PR on the ticket(s)?

@netlify
Copy link

netlify bot commented Aug 3, 2020

Deploy preview for helix-ui ready!

Built with commit 6000e4e

https://deploy-preview-745--helix-ui.netlify.app

@100stacks 100stacks added this to the HelixUI-v1.0.0-BETA milestone Aug 3, 2020
@100stacks 100stacks force-pushed the surf-2070-dynamic-tab-with-id-test branch from b709c75 to 6000e4e Compare August 4, 2020 01:28
Copy link
Contributor

@lalithkarikelli lalithkarikelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEV LGTM

Copy link
Collaborator

@badejayayesubabu badejayayesubabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEV LGTM

@100stacks 100stacks merged commit 91483cb into master Aug 10, 2020
@100stacks 100stacks deleted the surf-2070-dynamic-tab-with-id-test branch August 10, 2020 15:58
@100stacks 100stacks modified the milestones: HelixUI-v1.0.0-BETA, HelixUI-v1.0.0 Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants