Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tabset): dynamic tabs bug fixes Issue #516 #743

Merged
merged 1 commit into from
Jul 31, 2020
Merged

fix(tabset): dynamic tabs bug fixes Issue #516 #743

merged 1 commit into from
Jul 31, 2020

Conversation

100stacks
Copy link
Member

@100stacks 100stacks commented Jul 31, 2020 •
edited
Loading

Description - Dynamic Tabs

  • Fixes Creating tabs in empty tabset with Js  #516
  • fix for dynamic tabs
  • fix for no id on tabset on render
  • fix for no tabpanel on render
  • fix for no tab on render
  • fix for no tab or tabpanel on render
  • test an odd number of tabs and tabpanel
  • test an odd number of tabpanels and tab

screenshot: updated Tab Component tests (not skipped)

Screen Shot 2020-07-31 at 5 48 09 PM

What are the relevant story cards/tickets? Any additional PRs or other references?

Jira: SURF-1756

Before you request a review for this PR:

  • For UI changes, did you manually test in recent versions of modern browsers (Chrome, Firefox, and Safari)?
  • For UI changes, did you manually test in IE11 and legacy Edge?
  • Did you add component tests for any new code?
  • Did you run the component unit tests via yarn test to ensure all tests passed?
  • Did you include a screenshot of the component tests?
  • If you changed/added functionality, did you update the demo page and documentation?
  • If needed, did you add or modify the demo test page to test the changed/added functionality?
  • Did you assign reviewers?
  • In Jira, have you linked to this PR on the ticket(s)?

@100stacks 100stacks added this to the HelixUI-v0.24.0 milestone Jul 31, 2020
@netlify
Copy link

netlify bot commented Jul 31, 2020 •
edited
Loading

Deploy preview for helix-ui ready!

Built with commit bcfb3d3

https://deploy-preview-743--helix-ui.netlify.app

@100stacks 100stacks force-pushed the surf-1756-bug-fix-dynamic-tabs-on-connect branch 2 times, most recently from f131c81 to cdc8732 Compare July 31, 2020 01:31
@100stacks 100stacks changed the title fix(tabset): dynamic tabs bug Issue #516 fix(tabset): dynamic tabs bug fixes Issue #516 Jul 31, 2020
@100stacks 100stacks force-pushed the surf-1756-bug-fix-dynamic-tabs-on-connect branch 2 times, most recently from 33c8082 to 6bf6887 Compare July 31, 2020 04:29
badejayayesubabu
badejayayesubabu approved these changes Jul 31, 2020
View reviewed changes
Copy link
Collaborator

@badejayayesubabu badejayayesubabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEV LGTM

lalithkarikelli
lalithkarikelli approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@lalithkarikelli lalithkarikelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEV LGTM

@100stacks
fix(tabset): dynamic tabs bug fixes Issue #516
bcfb3d3 
* fix for dynamic tabs
* fix for no id on tabset
* fix for no tabpanel on render
* fix for no tab on render
* fix for no tabs or tabpanels on render
* test for odd number of tabs and tabpanel
* test for off number of tabpanels and tab
@100stacks 100stacks force-pushed the surf-1756-bug-fix-dynamic-tabs-on-connect branch from 6bf6887 to bcfb3d3 Compare July 31, 2020 22:41
@100stacks 100stacks merged commit d86663e into master Jul 31, 2020
@100stacks 100stacks deleted the surf-1756-bug-fix-dynamic-tabs-on-connect branch August 27, 2020 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalithkarikelli lalithkarikelli lalithkarikelli approved these changes

@badejayayesubabu badejayayesubabu badejayayesubabu approved these changes

Assignees
No one assigned
Labels
BUG FIX 📋 Testing JavaScript
Projects
None yet
Milestone
HelixUI-v0.24.0
Development

Successfully merging this pull request may close these issues.

Creating tabs in empty tabset with Js
3 participants
@100stacks @lalithkarikelli @badejayayesubabu