Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(hx-radio): test cases #725

Merged
merged 1 commit into from
Jul 20, 2020
Merged

test(hx-radio): test cases #725

merged 1 commit into from
Jul 20, 2020

Conversation

lalithkarikelli
Copy link
Contributor

@lalithkarikelli lalithkarikelli commented Jul 16, 2020 •
edited
Loading

Description

Test Cases <hx-radio>

image

What are the relevant story cards/tickets? Any additional PRs or other references?

Jira: SURF2018

Before you request a review for this PR:

  • Did you add component tests for any new code?
  • Did you run the component unit tests via yarn test to ensure all tests passed?
  • Did you include a screenshot of the component tests?
  • If you changed/added functionality, did you update the demo page and documentation?
  • If needed, did you add or modify the demo test page to test the changed/added functionality?
  • Did you assign reviewers?
  • In Jira, have you linked to this PR on the ticket(s)?

@netlify
Copy link

netlify bot commented Jul 16, 2020 •
edited
Loading

Deploy preview for helix-ui ready!

Built with commit 5567dc2

https://deploy-preview-725--helix-ui.netlify.app

@lalithkarikelli lalithkarikelli marked this pull request as ready for review July 16, 2020 11:41
badejayayesubabu
badejayayesubabu approved these changes Jul 16, 2020
View reviewed changes
Copy link
Collaborator

@badejayayesubabu badejayayesubabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEV LGTM

@100stacks 100stacks added this to the HelixUI-v0.24.0 milestone Jul 20, 2020
100stacks
100stacks approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev LGTM

@100stacks 100stacks merged commit fdf6a0c into HelixDesignSystem:master Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@100stacks 100stacks 100stacks approved these changes

@badejayayesubabu badejayayesubabu Awaiting requested review from badejayayesubabu

Assignees
No one assigned
Labels
📋 Testing
Projects
None yet
Milestone
HelixUI-v0.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lalithkarikelli @100stacks @badejayayesubabu