Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(hx-file-icon): surf-2008 #691

Merged
merged 1 commit into from
May 21, 2020
Merged

test(hx-file-icon): surf-2008 #691

merged 1 commit into from
May 21, 2020

Conversation

badejayayesubabu
Copy link
Collaborator

@badejayayesubabu badejayayesubabu commented May 19, 2020 •
edited
Loading

Description

Unit test <hx-file-icon>

image

What are the relevant story cards/tickets? Any additional PRs or other references?

Jira: SURF-2008(unit test case)

Before you request a review for this PR:

  • Did you add component tests for any new code?
  • Did you run the component unit tests via yarn test to ensure all tests passed?
  • Did you include a screenshot of the component tests?
  • If you changed/added functionality, did you update the demo page and documentation?
  • If needed, did you add or modify the demo test page to test the changed/added functionality?
  • Did you assign reviewers?
  • In Jira, have you linked to this PR on the ticket(s)?

@netlify
Copy link

netlify bot commented May 19, 2020 •
edited
Loading

Deploy preview for helix-ui ready!

Built with commit 2c25406

https://deploy-preview-691--helix-ui.netlify.app

@100stacks 100stacks added this to the HelixUI-v0.22.0 milestone May 19, 2020
@100stacks 100stacks marked this pull request as ready for review May 19, 2020 19:42
100stacks
100stacks requested changes May 19, 2020
View reviewed changes
Copy link
Member

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase and push an update.

100stacks
100stacks requested changes May 19, 2020
View reviewed changes
100stacks
100stacks requested changes May 20, 2020
View reviewed changes
Copy link
Member

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase and squash commits.

lalithkarikelli
lalithkarikelli approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@lalithkarikelli lalithkarikelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEV LGTM

100stacks
100stacks approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev LGTM

@100stacks 100stacks merged commit acd1c3f into HelixDesignSystem:master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@100stacks 100stacks 100stacks approved these changes

@lalithkarikelli lalithkarikelli lalithkarikelli approved these changes

Assignees
No one assigned
Labels
📋 Testing
Projects
None yet
Milestone
HelixUI-v0.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@badejayayesubabu @100stacks @lalithkarikelli @BadeJaya