Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ui): implement automated browser testing #687

Merged
merged 1 commit into from
May 18, 2020
Merged

test(ui): implement automated browser testing #687

merged 1 commit into from
May 18, 2020

Conversation

100stacks
Copy link
Member

@100stacks 100stacks commented May 12, 2020 •
edited
Loading

Description

  • Implemented automated browser testing in the following:
    • Chrome
    • Firefox
    • Safari
    • Edge
    • IE11
  • Runs full suite of tests in our TravisCI pipeline for each pull request.
  • Initial prototype for UI automated testing.
  • NOTE: We still need to manually check UI updates in the above supported browsers.

Screenshot of automated test runs

Screen Shot 2020-05-13 at 8 07 35 PM

Screenshot of TravisCI run

Screen Shot 2020-05-13 at 8 29 07 PM

What are the relevant story cards/tickets? Any additional PRs or other references?

Jira: SURF-2050

Before you request a review for this PR:

  • Did you manually test in recent versions of modern browsers (Chrome, Firefox, and Safari)?
  • Did you manually test in IE11 and legacy Edge?
  • Did you add unit tests for any new code if needed?
  • Did you run the unit tests via yarn test to ensure they all pass?
  • Did you update the demo page and documentation if you changed/added functionality?
  • If needed, did you add or modify the demo test page to test the changed/added functionality?
  • Did you assign reviewers?
  • Have you linked to this PR from the Jira ticket(s)?

@netlify
Copy link

netlify bot commented May 12, 2020 •
edited
Loading

Deploy preview for helix-ui ready!

Built with commit 3c37df9

https://deploy-preview-687--helix-ui.netlify.app

@100stacks 100stacks force-pushed the surf-2050-automate-ui-component-testing branch 13 times, most recently from 58c2bf9 to 723e2b4 Compare May 13, 2020 01:57
@100stacks 100stacks changed the title test(ui): add initial prototype automation tests test(ui): implement browser automation tests May 13, 2020
@100stacks 100stacks changed the title test(ui): implement browser automation tests test(ui): implement browser automation testing May 13, 2020
@100stacks 100stacks force-pushed the surf-2050-automate-ui-component-testing branch 13 times, most recently from c2faa40 to dbbd906 Compare May 14, 2020 00:26
@100stacks 100stacks force-pushed the surf-2050-automate-ui-component-testing branch 3 times, most recently from eec7c04 to 78cf33c Compare May 14, 2020 00:48
@100stacks 100stacks marked this pull request as ready for review May 14, 2020 00:54
@100stacks 100stacks changed the title test(ui): implement browser automation testing test(ui): implement automated browser testing May 14, 2020
@100stacks 100stacks added this to the HelixUI-v0.22.0 milestone May 14, 2020
@100stacks 100stacks force-pushed the surf-2050-automate-ui-component-testing branch from 78cf33c to c6831bb Compare May 14, 2020 01:40
@100stacks 100stacks force-pushed the surf-2050-automate-ui-component-testing branch 3 times, most recently from 7c36972 to b1d7609 Compare May 15, 2020 23:08
100stacks
100stacks commented May 15, 2020
View reviewed changes
src/elements/hx-error/index.spec.js
Comment on lines +64 to +68
if ( name !== null ) {
expect(name).to.be.equal('');
} else {
expect(name).to.be.null; // IE11 and Legacy Edge
}
Copy link
Member Author

@100stacks 100stacks May 15, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test was updated because IE11 and Legacy Edge (plus older modern browsers) do not have a "real" Shadow DOM. That's one of the main reasons why we need and use pollyfills.

@100stacks 100stacks force-pushed the surf-2050-automate-ui-component-testing branch 3 times, most recently from f0c6db6 to 3c37df9 Compare May 16, 2020 03:42
@100stacks
test(ui): implement automated browser component unit testing
3c37df9 
* implement automated browser testing in the CI pipeline
* runs full test suite in TravisCI for each pull request
* initial prototype of UI automated testing
* `<hx-error>` update named slot test for IE11 and Legacy Edge
lalithkarikelli
lalithkarikelli approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@lalithkarikelli lalithkarikelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEV LGTM

badejayayesubabu
badejayayesubabu approved these changes May 18, 2020
View reviewed changes
Copy link
Collaborator

@badejayayesubabu badejayayesubabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEV LGTM

@100stacks 100stacks merged commit 6d750c4 into master May 18, 2020
@100stacks 100stacks linked an issue May 21, 2020 that may be closed by this pull request
[SauceLabs] Massive Barrier to Entry for Contributions #312
Closed
@100stacks 100stacks mentioned this pull request May 21, 2020
Closed
@100stacks 100stacks deleted the surf-2050-automate-ui-component-testing branch May 26, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalithkarikelli lalithkarikelli lalithkarikelli approved these changes

@badejayayesubabu badejayayesubabu badejayayesubabu approved these changes

Assignees
No one assigned
Labels
📋 Testing ⚙️ Pipeline Milestone
Projects
None yet
Milestone
HelixUI-v0.22.0
Development

Successfully merging this pull request may close these issues.

[SauceLabs] Massive Barrier to Entry for Contributions
3 participants
@100stacks @lalithkarikelli @badejayayesubabu