Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(stepper content): surf1307 #675

Merged
merged 1 commit into from
Apr 29, 2020
Merged

refactor(stepper content): surf1307 #675

merged 1 commit into from
Apr 29, 2020

Conversation

lalithkarikelli
Copy link
Contributor

@lalithkarikelli lalithkarikelli commented Apr 10, 2020

JIRA: SURF-1307

LGTM's

  • Dev LGTM
  • Dev LGTM
  • Design LGTM

@netlify
Copy link

netlify bot commented Apr 10, 2020

Deploy preview for helix-ui ready!

Built with commit 0fcada9

https://deploy-preview-675--helix-ui.netlify.app

Copy link
Member

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments below.

@lalithkarikelli also based on your discovery, we may have a regression issue with <button> focus. Please fix.

@100stacks 100stacks added the PR: Comments Provided PR: Comments Provided label Apr 15, 2020
@lalithkarikelli lalithkarikelli marked this pull request as ready for review April 17, 2020 12:32
Copy link
Member

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job...almost there 👍

@100stacks 100stacks added PR: Comments Provided PR: Comments Provided and removed PR: Comments Provided PR: Comments Provided labels Apr 20, 2020
@100stacks 100stacks requested a review from araiford April 22, 2020 17:08
@100stacks 100stacks added this to the v0.21.0 milestone Apr 22, 2020
@100stacks 100stacks added the 🆕 FEATURE New HelixUI feature or addition label Apr 22, 2020
Copy link
Contributor

@araiford araiford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Collaborator

@badejayayesubabu badejayayesubabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEV LGTM

Copy link
Member

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev LGTM

@100stacks 100stacks merged commit 48a7fd5 into HelixDesignSystem:master Apr 29, 2020
@100stacks 100stacks added 🆕 🎉 HelixUI Component New HelixUI Component and removed 🆕 FEATURE New HelixUI feature or addition labels Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🆕 🎉 HelixUI Component New HelixUI Component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants