Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(button): tertiary button padding #673

Merged
merged 1 commit into from
Apr 30, 2020
Merged

refactor(button): tertiary button padding #673

merged 1 commit into from
Apr 30, 2020

Conversation

badejayayesubabu
Copy link
Collaborator

@badejayayesubabu badejayayesubabu commented Apr 8, 2020 •
edited by 100stacks
Loading

JIRA: SURF-1961

LGTM's

  • Design LGTM
  • Dev LGTM
  • Dev LGTM

@netlify
Copy link

netlify bot commented Apr 8, 2020 •
edited
Loading

Deploy preview for helix-ui ready!

Built with commit 018f334

https://deploy-preview-673--helix-ui.netlify.app

@badejayayesubabu badejayayesubabu changed the title refactor(button): Tertiary Button Padding refactor(button): tertiary button padding Apr 8, 2020
araiford
araiford approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@araiford araiford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

100stacks
100stacks requested changes Apr 8, 2020
View reviewed changes
Copy link
Member

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see changes.

@100stacks 100stacks marked this pull request as ready for review April 8, 2020 21:03
@100stacks 100stacks added this to the v0.21.0 milestone Apr 8, 2020
lalithkarikelli
lalithkarikelli approved these changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@lalithkarikelli lalithkarikelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEV LGTM

@100stacks 100stacks added the PR: Comments Provided PR: Comments Provided label Apr 15, 2020
@100stacks 100stacks added 🚧 Deprecation Deprecation that will be removed in a future release. and removed PR: Comments Provided PR: Comments Provided labels Apr 22, 2020
100stacks
100stacks requested changes Apr 28, 2020
View reviewed changes
@badejayayesubabu badejayayesubabu changed the base branch from master to helix-ui-0.17.x April 30, 2020 09:17
@badejayayesubabu badejayayesubabu changed the base branch from helix-ui-0.17.x to master April 30, 2020 09:17
100stacks
100stacks approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev LGTM

@100stacks 100stacks merged commit 24188ef into HelixDesignSystem:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@araiford araiford araiford approved these changes

@100stacks 100stacks 100stacks approved these changes

@lalithkarikelli lalithkarikelli lalithkarikelli approved these changes

Assignees
No one assigned
Labels
🚧 Deprecation Deprecation that will be removed in a future release.
Projects
None yet
Milestone
HelixUI-v0.21.0
Development

Successfully merging this pull request may close these issues.
5 participants
@badejayayesubabu @araiford @100stacks @lalithkarikelli @BadeJaya