update(HXFileInputElement): modify File Input component #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for helix-ui ready! Built with commit 11c9550 |
CITguy
suggested changes
Jun 3, 2019
catsiller
force-pushed
the
surf-1542-refactor-hx-file-input
branch
9 times, most recently
from
8b42db5 to
ae5a18d
Compare
CITguy
reviewed
Jun 13, 2019
| { label: 'Tertiary', val: 'hxTertiary' }, | ||
| { label: 'Primary', val: 'hxBtn hxPrimary' }, | ||
| { label: 'Secondary', val: 'hxBtn', default: true }, | ||
| { label: 'Tertiary', val: 'hxBtn hxTertiary' }, |
There was a problem hiding this comment.
Need to look into reducing repetitive .hxBtn class from refactored implementation, before the v0.17.0 release.
There was a problem hiding this comment.
do we want to do this in this p/r or no?
There was a problem hiding this comment.
not right now, but we do need a fast follow
CITguy
suggested changes
Jun 13, 2019
| <label for="fileInputDropZoneDemo"> | ||
| <hx-file-input class="hxBtn hxTertiary"> | ||
| browse your files | ||
| </hx-file-input> |
There was a problem hiding this comment.
Investigate extra inline spacing. (non-blocking)
catsiller
force-pushed
the
surf-1542-refactor-hx-file-input
branch
from
6b9e114 to
a60d2e8
Compare
CITguy
suggested changes
Jun 13, 2019
catsiller
force-pushed
the
surf-1542-refactor-hx-file-input
branch
from
650af45 to
0a1f84d
Compare
catsiller
force-pushed
the
surf-1542-refactor-hx-file-input
branch
from
0a1f84d to
11c9550
Compare
CITguy
changed the title
shipped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: surf-1542
LGTM's