Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(radio): add basic demo and enabled-focus-invalid tests #504

Merged
merged 1 commit into from
May 10, 2019
Merged

feat(radio): add basic demo and enabled-focus-invalid tests #504

merged 1 commit into from
May 10, 2019

Conversation

100stacks
Copy link
Member

@100stacks 100stacks commented May 10, 2019 •
edited by CITguy
Loading

  • add a basic radio demo:
<hx-radio-set>
  <input id="radBasicDemo" type="radio" />
  <label for="radBasicDemo">
    <hx-radio></hx-radio>
    Radio Label
  </label>
</hx-radio-set>

  • add Visually Invalid label for class="hxInvalid" styles

  • update Test Page to include tests for:

    • Pristine State:
      • Optional, Enabled, Focused, Invalid
      • Required, Enabled, Focused, Invalid
    • Dirty State:
      • Optional, Enabled, Focused, Invalid
      • Required, Enabled, Focused, Invalid
    • Visually Invalid State:
      • Optional, Enabled, Focused, Invalid
      • Required, Enabled, Focused, Invalid

JIRA: SURF-1635

LGTM's

  • Dev LGTM
  • Zoom LGTM

@HelixUI
Copy link
Contributor

HelixUI commented May 10, 2019 •
edited
Loading

Deploy preview for helix-ui ready!

Built with commit 0f00d13

https://deploy-preview-504--helix-ui.netlify.com

@100stacks 100stacks force-pushed the surf-1635-update-radio-demo-test branch 2 times, most recently from ec96e47 to 4371e29 Compare May 10, 2019 16:33
CITguy
CITguy suggested changes May 10, 2019
View reviewed changes
@100stacks 100stacks force-pushed the surf-1635-update-radio-demo-test branch from 4371e29 to 0f00d13 Compare May 10, 2019 17:33
@100stacks 100stacks added this to the v0.16.x milestone May 10, 2019
@100stacks 100stacks requested a review from catsiller May 10, 2019 17:40
catsiller
catsiller approved these changes May 10, 2019
View reviewed changes
Copy link
Contributor

@catsiller catsiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev lgtm

CITguy
CITguy approved these changes May 10, 2019
View reviewed changes
Copy link
Contributor

@CITguy CITguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev LGTM

@CITguy CITguy merged commit 5aed0d7 into master May 10, 2019
@CITguy CITguy deleted the surf-1635-update-radio-demo-test branch May 10, 2019 21:19
@CITguy CITguy added the :shipit: shipped label May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CITguy CITguy CITguy approved these changes

@catsiller catsiller catsiller approved these changes

Assignees
No one assigned
Labels
📋 Testing 📝 Documentation :shipit: shipped
Projects
None yet
Milestone
v0.16.x
Development

Successfully merging this pull request may close these issues.
4 participants
@100stacks @HelixUI @CITguy @catsiller