Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(HXMenuElement): use Positionable mixin #402

Merged
merged 1 commit into from
Dec 11, 2018
Merged

refactor(HXMenuElement): use Positionable mixin #402

merged 1 commit into from
Dec 11, 2018

Conversation

100stacks
Copy link
Member

@100stacks 100stacks commented Dec 6, 2018 •
edited by catsiller
Loading

  • Refactored HXMenuElement to make use of the Positionable mixin.

JIRA: SURF-1497

LGTM's

  • Dev LGTM
  • Zoom LGTM

@100stacks 100stacks added this to the v0.15.0-rc.1 milestone Dec 6, 2018
@HelixUI
Copy link
Contributor

HelixUI commented Dec 6, 2018 •
edited
Loading

Deploy preview for helix-ui ready!

Built with commit ff11e04

https://deploy-preview-402--helix-ui.netlify.com

@100stacks 100stacks force-pushed the surf-1497-refactor-menus-to-use-mixins branch from 94c5c4a to e51b9f0 Compare December 6, 2018 04:49
@100stacks
Copy link
Member Author

100stacks commented Dec 6, 2018 •
edited
Loading

<hx-menu>

image

outdated screenshot

CITguy
CITguy suggested changes Dec 6, 2018
View reviewed changes
CITguy
CITguy suggested changes Dec 6, 2018
View reviewed changes
Copy link
Contributor

@CITguy CITguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update <hx-menu> docs, too.

@CITguy CITguy modified the milestones: v0.15.0-rc.1, v0.15.0-rc.2 Dec 6, 2018
@100stacks 100stacks force-pushed the surf-1497-refactor-menus-to-use-mixins branch from e51b9f0 to 83da2dc Compare December 10, 2018 17:29
@100stacks
Copy link
Member Author

@CITguy, I edited and updated the screenshot for the <hx-menu> docs:

#402 (comment)

catsiller
catsiller approved these changes Dec 10, 2018 •
edited
Loading
View reviewed changes
catsiller
catsiller suggested changes Dec 10, 2018
View reviewed changes
Copy link
Contributor

@catsiller catsiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had a couple of questions to double check about!! in comments

@100stacks 100stacks force-pushed the surf-1497-refactor-menus-to-use-mixins branch from 83da2dc to ff11e04 Compare December 11, 2018 00:28
CITguy
CITguy approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@CITguy CITguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev LGTM

catsiller
catsiller approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@catsiller catsiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zoom lgtm

@CITguy CITguy merged commit ff406ca into master Dec 11, 2018
@CITguy CITguy deleted the surf-1497-refactor-menus-to-use-mixins branch December 11, 2018 16:58
@CITguy CITguy changed the title refactor(hx-menu): surf-1497 use positionable mixin refactor(hx-menu): SURF-1497 use Positionable mixin Dec 11, 2018
@CITguy CITguy changed the title refactor(hx-menu): SURF-1497 use Positionable mixin refactor(HXMenuElement): use Positionable mixin Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CITguy CITguy CITguy approved these changes

@catsiller catsiller catsiller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.15.0-rc.2
Development

Successfully merging this pull request may close these issues.
4 participants
@100stacks @HelixUI @CITguy @catsiller