Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Quest: roof:material #567

Open
wants to merge 1 commit into
base: modified
Choose a base branch
from

Conversation

ravenfeld
Copy link

I'm going to split the request in 2.
#443

Creating a quest to add roof material

The most complicated part is making the images once you understand how it works ;)

Screenshot_20240702_223022

@Helium314
Copy link
Owner

Similar to builing material quest: please reduce size of the images, it's more than 5 MB currently, and the strings could be re-used (after building material quest is merged).
Other than that it's mostly minor things:

  • not sure if tin and generic metal should be separate. I wouldn't be able to tell that a roof is made of tin, probably same for zinc. But maybe it's easy if you have some experience.
  • I found the concrete and tar paper images not really helpful. For tar paper, just some increased contrast might help a lot (and maybe for concrete too)
  • the asphalt image looks strange, on my phone at first I thought it was a lake
  • quest icon could be nicer, but at the same time making a nice looking tile roof or whatever seems to be not worth the effort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants