Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Guidepost Sports quest #496

Merged
merged 16 commits into from
Dec 24, 2023
Merged

Add Guidepost Sports quest #496

merged 16 commits into from
Dec 24, 2023

Conversation

mcliquid
Copy link

Fixes #467

@mcliquid mcliquid changed the title First modifications of the recycling quest Add Guidepost Sports quest Nov 20, 2023
@Helium314
Copy link
Owner

Considering streetcomplete#5412, this PR should be done before the mentioned changes.
Do you want to continue here, or do you need anything from me?
As far as I understand from #467 you already have found some icons, so there should not be much work left.

and !disused
and !guidepost
""".toElementFilterExpression() }

This comment was marked as resolved.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not include this globally. We also have a lot of maps for cycle routes, but only a very small proportion overall. I would say that would be almost spammy even for SCEE. If you want to, you can edit the quest query individually. What do you think?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, this is ok too

@mcliquid mcliquid marked this pull request as ready for review December 22, 2023 12:47
@mcliquid
Copy link
Author

@Helium314 What would be the easiest way to switch the title color from white to black?

@Helium314
Copy link
Owner

You will need to adjust the layout xml and set the new layout in the quest form in onCreate, e.g. imageSelector.cellLayoutId = R.layout.cell_icon_select_with_label_below
But note that it should also look ok with (nearly) black background

@mcliquid
Copy link
Author

Hm, should I leave it white instead?
I could add a background color to the icons instead.

@Helium314
Copy link
Owner

I noticed the recycling quest does have a text color suitable for the chosen theme, so there should be some cellLayoutId you can use.

@Helium314
Copy link
Owner

Do you still want to add the guidepost=simple other answer?

@mcliquid
Copy link
Author

@Helium314
Copy link
Owner

The answers should use actual sport, having Bicycle, Horse and Ski in there feels wrong.
The quest looks like it could actually be an OsmFilterQuestType instead of OsmElementQuestType.

Otherwise it looks good!

@mcliquid
Copy link
Author

Thank you for helping! I've switched to FilterQuestType and changed the strings. Changing MTB to "Mountain biking" feels wrong, so I've kept "MTB". The Olympic Committee calls it "Cycling Mountain Bike" - that's just even weirder.

@Helium314 Helium314 merged commit d3dab90 into Helium314:modified Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Quest: For which sport is this guidepost intended? (information=guidepost/route_marker)
3 participants