-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Guidepost Sports quest #496
Add Guidepost Sports quest #496
Conversation
Considering streetcomplete#5412, this PR should be done before the mentioned changes. |
and !disused | ||
and !guidepost | ||
""".toElementFilterExpression() } | ||
|
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not include this globally. We also have a lot of maps for cycle routes, but only a very small proportion overall. I would say that would be almost spammy even for SCEE. If you want to, you can edit the quest query individually. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, this is ok too
...src/main/java/de/westnordost/streetcomplete/quests/guidepost_sport/AddGuidepostSportsForm.kt
Outdated
Show resolved
Hide resolved
@Helium314 What would be the easiest way to switch the title color from white to black? |
You will need to adjust the layout xml and set the new layout in the quest form in |
Hm, should I leave it white instead? |
I noticed the recycling quest does have a text color suitable for the chosen theme, so there should be some |
Do you still want to add the |
app/src/main/java/de/westnordost/streetcomplete/quests/guidepost_sport/AddGuidepostSports.kt
Outdated
Show resolved
Hide resolved
UI fixed and functionality works: |
The answers should use actual sport, having Bicycle, Horse and Ski in there feels wrong. Otherwise it looks good! |
Thank you for helping! I've switched to FilterQuestType and changed the strings. Changing |
Fixes #467