-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no package.json #20
Comments
You are correct, currently you can install the package through npm install
mitol. Although today later in the afternoon I will make a new release with
included body parse fix.
…On 16 April 2018 at 17:50, Brandon Ros ***@***.***> wrote:
npm install https://github.com/Helidium/Mitol.git won't work because you
don't have a package.json in the repo
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#20>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABDmtBMjkaWdthsWYCdxrNaNuU7LdagSks5tpL2xgaJpZM4TWyxO>
.
|
Are you also going to include a package.json in the repo? |
I can include the package.json, but I dont believe it will work as
expected. because the root of the project is a C++ source code.
You can manually compile if you download all the sources, go into node
folder, copy the root src folder into node folder and run the following:
node-gyp rebuild > build_log.txt 2>&1 || exit 0
…On 16 April 2018 at 18:12, Brandon Ros ***@***.***> wrote:
Are you also going to include a package.json in the repo?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#20 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABDmtGp2RdwDJ-KLo1PfjiNO5Mf4On8Bks5tpMMBgaJpZM4TWyxO>
.
|
I'm working on a PR now. You are missing Makefile + binding.gyp in the repo as well. |
Its in the node folder...
…On 16 April 2018 at 18:20, Brandon Ros ***@***.***> wrote:
I'm working on a PR now. You are missing Makefile + binding.gyp in the
repo as well.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#20 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABDmtPpMvnvdiI1eC_ZxLxfFmjo9ZruHks5tpMS9gaJpZM4TWyxO>
.
|
But you are correct it should be in the root. Thank you for your
contributions Brandon :)
Regards,
…On 16 April 2018 at 18:20, Marko Biskup ***@***.***> wrote:
Its in the node folder...
On 16 April 2018 at 18:20, Brandon Ros ***@***.***> wrote:
> I'm working on a PR now. You are missing Makefile + binding.gyp in the
> repo as well.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#20 (comment)>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/ABDmtPpMvnvdiI1eC_ZxLxfFmjo9ZruHks5tpMS9gaJpZM4TWyxO>
> .
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
npm install https://github.com/Helidium/Mitol.git
won't work because you don't have a package.json in the repoThe text was updated successfully, but these errors were encountered: