Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relay - Basic Auth handler compares the username against the wrong value, so always fails #13

Closed
1 task done
beforan opened this issue Jan 28, 2025 · 0 comments · Fixed by #19
Closed
1 task done
Assignees
Milestone

Comments

@beforan
Copy link
Member

beforan commented Jan 28, 2025

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Due to design changes, the Basic Auth handler compares the submitted credentials' username against the wrong value from the database.

Expected Behavior

The handler should compare the expected value and succeed when the value is correct.

Steps To Reproduce

  1. Have Relay
  2. Add a subnode with a username
  3. Make any request e.g. to get a job for a collection, using the username, password and collection id from 2.
  4. The request will fail

It should succeed.

Environment

- OS: Fedora 41
- Other environment details:

I'm part of a Project Team

UoN Health Informatics

Anything else?

No response

Are you willing to contribute to resolve this issue?

✅ Yes, me or my team intend to do the development.

@beforan beforan self-assigned this Jan 28, 2025
@github-project-automation github-project-automation bot moved this to MoreInfo in Hutch Backlog Jan 28, 2025
@beforan beforan moved this from MoreInfo to Committed in Hutch Backlog Jan 28, 2025
@AndyRae AndyRae added this to the Relay v1.0.0 milestone Jan 28, 2025
@beforan beforan moved this from Committed to In Progress in Hutch Backlog Jan 28, 2025
@beforan beforan mentioned this issue Jan 29, 2025
3 tasks
beforan added a commit that referenced this issue Jan 29, 2025
* Basic Auth bug fix

* unit testing BasicAuthHandler

* more compliant log messaging
@github-project-automation github-project-automation bot moved this from In Progress to Done in Hutch Backlog Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants