feat: verify deployed task definition #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If ECS circuit breaker is enabled for a service the ECS deploy step can give a false successful result, as the triggered rollback is detected as "healthy". The task definition ARN can be checked against the expectation as a workaround. See: aws-actions/amazon-ecs-deploy-task-definition#191 TIS21-4819 TIS21-5327
Judge40
requested review from
a team and
JosephKelly
and removed request for
a team
JosephKelly
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If ECS circuit breaker is enabled for a service the ECS deploy step can give a false successful result, as the triggered rollback is detected as "healthy".
The task definition ARN can be checked against the expectation as a workaround.
See:
aws-actions/amazon-ecs-deploy-task-definition#191
TIS21-4819
TIS21-5327