Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hxlibc improvements to the HXCPP tool #37

Merged
merged 6 commits into from
Mar 25, 2014
Merged

hxlibc improvements to the HXCPP tool #37

merged 6 commits into from
Mar 25, 2014

Conversation

jgranick
Copy link
Contributor

The first commit separates the HXCPP run tool into multiple files, per class. This should make it a bit easier to maintain.

The second commit performs a little bit of standardization on the code, following the current code style. This helps remove bad indenting, and other inconsistencies -- this pass was not too dramatic, I did not want to assume that certain kinds of spaces, etc, were always intended to be similar.

The third commit includes improvements made from the hxlibc tool, primarily, it includes additional logic for logging, running process and working with paths. The error messages in places are cleaned a bit, and it automatically uses ASCII coloring when available. Errors will also not throw a stack trace from the HXCPP tool, as an error when calling g++ (for example) is not relevant to the internals of the tool.

@hughsando
Copy link
Member

I notice that this has removed the multi-threaded output reading. Was this
done for a reason?

On Tue, Mar 25, 2014 at 5:36 AM, Joshua Granick notifications@github.comwrote:

The first commit separates the HXCPP run tool into multiple files, per
class. This should make it a bit easier to maintain.

The second commit performs a little bit of standardization on the code,
following the current code style. This helps remove bad indenting, and
other inconsistencies -- this pass was not too dramatic, I did not want to
assume that certain kinds of spaces, etc, were always intended to be
similar.

The third commit includes improvements made from the hxlibc tool,
primarily, it includes additional logic for logging, running process and
working with paths. The error messages in places are cleaned a bit, and it
automatically uses ASCII coloring when available. Errors will also not
throw a stack trace from the HXCPP tool, as an error when calling g++ (for

example) is not relevant to the internals of the tool.

You can merge this Pull Request by running

git pull https://github.com/jgranick/hxcpp patch-2

Or view, comment on, or merge it at:

#37
Commit Summary

  • Refactor HXCPP run tool into multiple files
  • More consistent code style
  • Tool improvements

File Changes

Patch Links:

Reply to this email directly or view it on GitHubhttps://github.com//pull/37
.

@jgranick
Copy link
Contributor Author

I have made fixes, so now everything appears to work properly. I had not noticed some of the other changes in how threaded builds work, using the original threaded process/output code, it's working great ;)

hughsando added a commit that referenced this pull request Mar 25, 2014
hxlibc improvements to the HXCPP tool
@hughsando hughsando merged commit 2f3c5a6 into HaxeFoundation:master Mar 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants