Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated non-prototype warnings in Zlib for non-MSVC compilers. #1144

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Conversation

MAJigsaw77
Copy link
Contributor

This PR adds the -Wno-deprecated-non-prototype compiler flag to the Zlib build process for non-MSVC compilers. The purpose of this change is to remove warnings related to deprecated non-prototype function definitions.

@MAJigsaw77
Copy link
Contributor Author

Once hxcpp starts using zlib 1.3 this change can be removed as mentioned here

@hughsando
Copy link
Member

This flag itself causes warnings when clang is older (<15 ?). This could be countered with <compilerflag value="-Wno-unknown-warning-option" unless="MSVC_VER" /> It may also need <compilerflag value="-Wno-unknown-warning" unless="MSVC_VER" /> for gcc. Not a bad solution, but upgrading zlib may be better.

@MAJigsaw77
Copy link
Contributor Author

This flag itself causes warnings when clang is older (<15 ?). This could be countered with <compilerflag value="-Wno-unknown-warning-option" unless="MSVC_VER" /> It may also need <compilerflag value="-Wno-unknown-warning" unless="MSVC_VER" /> for gcc. Not a bad solution, but upgrading zlib may be better.

I'll add <compilerflag value="-Wno-unknown-warning" unless="MSVC_VER" /> in any case.

@hughsando hughsando merged commit 9c8cc14 into HaxeFoundation:master Aug 28, 2024
120 checks passed
@hughsando
Copy link
Member

We will see how this goes for now, and think about zlib updates. Thanks!

@MAJigsaw77 MAJigsaw77 deleted the patch-1 branch August 28, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants