Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ssl] Separate mbedtls c files from SSL.cpp #1125

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

tobil4sk
Copy link
Member

#1111 fixed an error with old android ndks which used old versions of gcc that didn't set c99 by default. However, it turns out this breaks new ndks, because they complain about setting -std=c99 when compiling a c++ file (SSL.cpp):

Error: error: invalid argument '-std=c99' not allowed with 'C++'

We can fix the issue by separating the c files from the c++ files so that SSL.cpp is compiled without this flag.

@tobil4sk
Copy link
Member Author

@Simn Please could this be merged? This is starting to show up as a warning with gcc now as well:

warning: command-line option ‘-std=c99’ is valid for C/ObjC but not for C++

@Simn Simn merged commit 6d0b37b into HaxeFoundation:master Jul 11, 2024
100 checks passed
@tobil4sk tobil4sk deleted the fix/mbedtls-c99-error branch July 11, 2024 21:15
@tobil4sk tobil4sk mentioned this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants