CI - UTest2 #1120
Merged
CI - UTest2 #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like these are legitimate failures and I can recreate them, will investigate. |
|
Fixed the few failing tests, both seem to be variants of what seems to be new optimisations done my MSVC triggered by the test suite code changes. I've previously seen this with the GC tests which fail when compiling with C++17 on Windows (#1060). I've worked around this by adding more dummy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tobil4sk noticed that the change I made to avoid the flakey Mac test wasn't actually running. I assumed the std tests were using utest, but no, the results are manually collected.
Initially I was just going to get that new test to run, but then I thought "in for a penny in for a pound" and decided to move those std tests to utest. Then I discovered hxcpp doesn't use utest and instead has a vendored version of the old haxe 3 test stuff.
So here's the hxcpp test suite migrated to UTest2 / utest git.