check for different urls when running haxelib git
#640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobil4sk
reviewed
Aug 17, 2024
|
how was this one looking? Should I add tests for this? |
Yes please, a test would be useful! |
It only has to be checked when running interp scripts, so we can avoid checking it in other cases.
…ion#638) * submodule stuff in progress * perhaps a submodule fix? * revert the dipshit logging * update run.n * we dont need to spit out every log, but we should use the threads? * comment out the unneeded git fetch * small reorder / remove redundant `git submodule init` * uncomment the lib deletion, since we've ran into issues related * fix for stderr/stdout related hangs on non-windows when installing git submodules * remove git progress code * run.n * remove whitespace * proper non-cli coupled logging * remove unneeded logging/git --quiet flag code for the time being * run.n * remove unneeded FsUtils.deleteRec() * run.n * remove testing print * run.n * removed unused import and throw an exception on submodule error * add message for SubmoduleError
…cal or not testing in progress accident git thingie
ninjamuffin99
force-pushed
the
update-remote-url
branch
from
089b365
to
da51ad0
Compare
|
finally got around to figuring out how to draft up a test! I wrote it in |
tobil4sk
reviewed
Sep 26, 2024
|
|
||
| if (url != null && libUrl != null && url != libUrl) | ||
| { | ||
| if (!userInterface.confirm('Update remote url: "${libUrl}" with "${url}"')) { |
There was a problem hiding this comment.
This introduces a new cli interaction that wasn't present before, it may be best to simply overwrite unless there are uncommitted changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently running
haxelib gitit doesn't check the differences in remote urls.Running
haxelib git flixel https://github.com/HaxeFlixel/flixel.gitwill correctly installflixel. However, if you then try running with a different urlhaxelib git flixel https://github.com/FunkinCrew/flixel.gitit doesn't properly update / reinstall from the new URL. Going into the cloned repoflixel/gitand runninggit config --get remote.origin.urlwill showhttps://github.com/HaxeFlixel/flixel.gitrather than the new one.This PR runs a check from the currently installed haxelib's git remote to the newly inputted one, and if it's different, it will ask if you want to install the new one.
Right now I just have it implemented for git, not mecurial. Current implementation is agnostic to whether someone has an SSH remote url (
git@github.com:HaxeFlixel/flixel) or HTTP remote url (https://github.com/HaxeFlixel/flixel)