Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MIT license to haxelib #630

Merged
merged 2 commits into from
May 25, 2024
Merged

Add MIT license to haxelib #630

merged 2 commits into from
May 25, 2024

Conversation

Maniues
Copy link
Contributor

@Maniues Maniues commented May 24, 2024

This patch adds MIT license to this repo (as stated in package.json and haxelib.json).

You can modify this license to add to copyright notice other contributors included in haxelib.json.

@Maniues
Copy link
Contributor Author

Maniues commented May 25, 2024

@Simn, @andyli, could you merge this? License is the fundamental for contribution in Open Source project.

@Simn
Copy link
Member

Simn commented May 25, 2024

I have some vague memory of the licensing being a bit more difficult for haxelib in particular, but I don't remember any details.

@Maniues
Copy link
Contributor Author

Maniues commented May 25, 2024

@Simn As I said earlier, many Haxe projects have licensing issues (usually there is no LICENSE file in git repo). I wrote an email to the Haxe Foundation once and repeated the issue recently, but never received any response.

As I understand it, these are Open Source projects. All in all, very good and useful. I don't know how it's possible that they have such problems, but I want to help solve them, hence all the PR with adding licenses.

Could you check what the haxelib licensing issues were? The haxelib.json file says "MIT", so I assumed that this license covers this project and it should be there, but I don't think it would be bad if it was a mix of e.g. Apache-MIT or just GPL or something similar.

@Simn
Copy link
Member

Simn commented May 25, 2024

Ah okay, if the haxelib.json already says it then I guess somebody has thought about it before.

@Simn Simn merged commit be2fff1 into HaxeFoundation:development May 25, 2024
@Maniues
Copy link
Contributor Author

Maniues commented May 25, 2024

@Simn maybe you meant this #535

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants