-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for customMetas and customDefines fields #573
Merged
tobil4sk
merged 11 commits into
HaxeFoundation:development
from
kLabz:feature/custom-defines-meta
Nov 23, 2022
Merged
Add support for customMetas and customDefines fields #573
tobil4sk
merged 11 commits into
HaxeFoundation:development
from
kLabz:feature/custom-defines-meta
Nov 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
tobil4sk
reviewed
Nov 19, 2022
Really neat stuff! :D This will solve #262. We might also want to add some validation, so that when a library is submitted we make sure the files actually exist and that they contain valid data, since we do that with |
tobil4sk
reviewed
Nov 19, 2022
Also guard against previous haxe versions
This reverts commit cb7976c.
This looks good to me. @tobil4sk feel free to merge if there's nothing else to do! |
tobil4sk
pushed a commit
that referenced
this pull request
Mar 31, 2023
Add support for documentation field with metadata and defines
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those fields will be used in HaxeFoundation/haxe#10858