Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for customMetas and customDefines fields #573

Merged
merged 11 commits into from
Nov 23, 2022

Conversation

kLabz
Copy link
Contributor

@kLabz kLabz commented Nov 19, 2022

Those fields will be used in HaxeFoundation/haxe#10858

@tobil4sk
Copy link
Member

Really neat stuff! :D This will solve #262.

We might also want to add some validation, so that when a library is submitted we make sure the files actually exist and that they contain valid data, since we do that with haxelib.json.

src/haxelib/Data.hx Outdated Show resolved Hide resolved
@skial skial mentioned this pull request Nov 23, 2022
1 task
@Simn
Copy link
Member

Simn commented Nov 23, 2022

This looks good to me.

@tobil4sk feel free to merge if there's nothing else to do!

@tobil4sk tobil4sk merged commit 4e4b034 into HaxeFoundation:development Nov 23, 2022
@kLabz kLabz deleted the feature/custom-defines-meta branch November 23, 2022 23:03
tobil4sk pushed a commit that referenced this pull request Mar 31, 2023
Add support for documentation field with metadata and defines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants