Map toString brackets #9260
Merged
Map toString brackets #9260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
RealyUniqueName
requested changes
Mar 23, 2020
|
I'm not sure If we should treat this as a breaking change. I'd merge it for 4.1. |
This reverts commit 3e1d9a0.
|
CI disaster is not related. @Simn are you ok with this for 4.2? |
|
There are some failing tests on the C++ target here. |
|
This depends on HaxeFoundation/hxcpp#892 |
|
Jvm fail is not related. I can revert latest commit now and this probably good to merge (after HaxeFoundation/hxcpp#892). |
This reverts commit faa9fe8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for copy, i just recreated Haxe repo last week trying to trigger CI.
Closes #8030