Remove @:overload from Reflect.makeVarArgs #11853
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #11843 I came across this function which has an
@:overload
in order to support bothArray<Dynamic>->Void
andArray<Dynamic>->Dynamic
functions. This only works incidentally on some targets because the old@:overload(function)
syntax doesn't perform the same checks that properoverload function
s do. For example, to the JVM target both signatures are the same, so the compiler doesn't know which overload to resolve to.Since this is only done so that we can support both
Dynamic
andVoid
callback returns, I think using a type parameter instead achieves the same goal without the overload hassle.I had the formatter on so the diff is a bit bigger.