Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[make] Compile haxelib binary with hxcpp #11755

Open
wants to merge 8 commits into
base: development
Choose a base branch
from
Open

[make] Compile haxelib binary with hxcpp #11755

wants to merge 8 commits into from

Commits on Sep 4, 2024

  1. [make] Compile haxelib binary with hxcpp 

    This avoids the dependency on neko, which means that haxe no longer has
to be packaged with neko as a mandatory dependency.

Haxelib has to be run through interp first in order to install hxcpp.
    @tobil4sk
    tobil4sk committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    9c3a1f2 View commit details
    Browse the repository at this point in the history

  2. [make] Install hxcpp quietly 

    Avoid excessive logs in CI
    @tobil4sk
    tobil4sk committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    cfee6c3 View commit details
    Browse the repository at this point in the history

  3. [cpp] Do not write hxcpp path if not compiling 

    When building the haxelib binary, no haxelib executable is available
in PATH yet, so the haxelib call is a problem.

With `-D no-compilation`, haxe doesn't use/run hxcpp at all so this path
is not very meaningful. The user may compile manually with a completely
different version of hxcpp.

Either way, this value is completely ignored by hxcpp:
https://github.com/HaxeFoundation/hxcpp/blob/08f88ff314eeaa165dd76272f92c8030cc879ec2/tools/hxcpp/BuildTool.hx#L1729-L1732
    @tobil4sk
    tobil4sk committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    9b553b8 View commit details
    Browse the repository at this point in the history

  4. Update haxelib submodule 

    We need HaxeFoundation/haxelib#646 because at
the time of running `$(HAXELIB_INTERP) run hxcpp ...`, no `haxe`
executable is available in PATH yet.
    @tobil4sk
    tobil4sk committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    cfc7648 View commit details
    Browse the repository at this point in the history

  5. [make] Fix path issues on windows 

    The makefile was using cygwin paths, but haxe expects native windows
paths
    @tobil4sk
    tobil4sk committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    9247bef View commit details
    Browse the repository at this point in the history

  6. [make] Use haxelib git to install hxcpp 

    Installing from lib.haxe.org via ssl causes problems.

On Mac, it downloads incorrectly whenever the `--quiet` flag is used.

On Windows, it gives the error:
```
Error: Failed with error: X509 - Certificate verification failed, e.g. CRL, CA or signature check failed
```
    @tobil4sk
    tobil4sk committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    3d5b85f View commit details
    Browse the repository at this point in the history

  7. [make] Remove \r from haxelib libpath output 

    Otherwise we end up with the carriage return still being there on
windows.
    @tobil4sk
    tobil4sk committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    2df5372 View commit details
    Browse the repository at this point in the history

  8. [make] Clean up haxelib build output

    @tobil4sk
    tobil4sk committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    a502318 View commit details
    Browse the repository at this point in the history