-
-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Int128 + its numeral literal suffix #11750
base: development
Are you sure you want to change the base?
Implement Int128 + its numeral literal suffix #11750
Conversation
…functions that need it
I'm not sure if this is the right place to ask for help, the Issues tab might be more sufficient. |
Actually I prefer a PR here because it's easier to reason about the code and see the failing tests, so I think this is a good initiative. |
How come 14 tests failed? |
That's what the details tab are for, perhaps you can click on them :P |
This is an error from linux build 4.08.1:
|
Now I'm just waiting for this pr to get merged |
balls |
Ok |
This adds the ability to construct a `haxe.io.Bytes` out of part of the file's bytes in the most efficient way possible.
File.getBytes
to have starting position and length + Implement Int128 + its numeral literal suffix
File.getBytes
to have starting position and length + Implement Int128 + its numeral literal suffix
Ignore the commits adter the hrr 717 mention. It was an accident and I didn't mean to do so. |
100 commits. Oh boy. I wasted the 15 of them lol |
Everything in the pure haxe version is done but the issue is that
Int128.mul(a, b)
doesn't multiply properly with the value bigger than 1.8e19 which means the number will overflow. So, I was wondering if any of you could please fix that issue.