[macro] Remove CompilationServer.setModuleCheckPolicy options #11615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….setModuleFileSystemCheckPolicy
|
I agree with the change generally but the renaming seems a bit pointless... |
kLabz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm really not sure it ever worked properly, and was often triggering
X is redefined from Xerrors.Since hxb (#11504) has been merged,
CompilationServer.setModuleCheckPolicyseems utterly broken (as expected for things that would tend to break over time with compilation server: with hxb, it break fast) and triggersBadModuleerrors.. which are new errors that would have resulted in aX is redefined from Xbefore.I'm currently removing it entirely, but I can see some real use case in there forI kept functionality for previousCheckFileContentModification(and possiblyNoCheckFileTimeModification) policy which seems like a legit one. Will look into simplifying the previous API to only allow these two.CheckFileContentModificationandNoCheckFileTimeModificationpolicies.Closes #6993