-
-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add class_path as a record type #11477
Conversation
To be honest, the diff here looks pretty awkward with all the |
We don't know the name of the lib though because haxelib doesn't tell us in an obvious way, and I can't be parsed to arse it out of the preceeding -D or something...
Since we always have the empty class path anyway, this should just work via normal recursion. Maybe.
I ended up doing a bit more than I originally wanted, but all these should be good changes:
Something else we could do now is associate modules with class paths. I'm not sure yet if this is useful for the compilation cache, but it's good to have the option. @kLabz Would be good to test Shiro codebases with this, there's a chance that I missed some behavioral change. |
# Conflicts: # src/compiler/retyper.ml
# Conflicts: # src/typing/macroContext.ml
* add class_path as a record type * one thing led to another... * add secret -libcp CLI argument to distinguish library class paths We don't know the name of the lib though because haxelib doesn't tell us in an obvious way, and I can't be parsed to arse it out of the preceeding -D or something... * embrace plural * don't debug * make find_file control flow a bit less silly * check current file while caching so we don't have to find it afterwards * do we actually need this special case? Since we always have the empty class path anyway, this should just work via normal recursion. Maybe. * store class path alongside file * so that's what that does
Instead of a string list we now have a record with a path and a kind. Currently, the only kind is
Directory
because all I want for now is parity. Ultimately, I'd like to look into zip/archive class paths, and distinguish user/lib/std class paths explicitly.