Fix make error related to pcre #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wrong variable was being used when building the regex part of the standard library which was preventing compilation without a global installation.
|
Please contribute to the PR instead so everything can be merged at once. |
|
The other PR fixes this as well, but I thought it might be good to have this as a separate PR so that the current build works even if it takes a while for the other one to be merged. |
|
@ncannasse A user came across this issue recently on the Haxe discord. This PR simply fixes a typo introduced in #520, and it would be useful to have by itself unless the PCRE2 PR is likely to be merged any time soon. Please could you merge this? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrong variable was being used when building the regex part of the
standard library which was preventing compilation without a global
installation.
Only required if #515 is not merged first.