Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Upgrade react-native #164

Merged
merged 12 commits into from
May 17, 2022
Merged

chore: Upgrade react-native #164

merged 12 commits into from
May 17, 2022

Conversation

r4mmer
Copy link
Member

@r4mmer r4mmer commented Apr 19, 2022

Acceptance Criteria

  • Upgrade react-native version to v0.67.4
  • remove unused dependencies
  • upgrade used dependencies

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@r4mmer
chore: Upgrade react-native
34f9c29 
chore: remove unused dependencies
chore: upgrade used dependencies
@r4mmer r4mmer self-assigned this Apr 19, 2022
andreabadesso
andreabadesso requested changes May 12, 2022
View reviewed changes
__tests__/App-test.js Show resolved Hide resolved
android/app/build.gradle Show resolved Hide resolved
android/app/build.gradle Show resolved Hide resolved
android/app/src/debug/java/com/hathormobile/ReactNativeFlipper.java Show resolved Hide resolved
android/gradlew Show resolved Hide resolved
ios/HathorMobileTests/HathorMobileTests.m Show resolved Hide resolved
ios/Podfile.lock Show resolved Hide resolved
shim.js Show resolved Hide resolved
src/components/NewHathorButton.js Show resolved Hide resolved
src/screens/InitWallet.js Show resolved Hide resolved
pedroferreira1
pedroferreira1 reviewed May 13, 2022
View reviewed changes
Copy link
Member

@pedroferreira1 pedroferreira1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you commit android/app/debug.keystore file?

.gitignore Show resolved Hide resolved
android/app/src/main/AndroidManifest.xml Show resolved Hide resolved
android/app/src/main/res/drawable/rn_edit_text_material.xml Show resolved Hide resolved
package.json Show resolved Hide resolved
@r4mmer
Copy link
Member Author

r4mmer commented May 13, 2022

Why did you commit android/app/debug.keystore file?

The upgrade helper specifically excluded all keystore files in gititnore except the debug.keystore. I thought that since this file should only be used in dev it wouldn't have much of an impact.

But what do you think @pedroferreira1, should we remove it?

@pedroferreira1
Copy link
Member

But what do you think @pedroferreira1, should we remove it?

We can keep it, no problem

@pedroferreira1 pedroferreira1 self-requested a review May 16, 2022 16:13
pedroferreira1 and others added 2 commits May 17, 2022 10:10
@pedroferreira1 @r4mmer
feat: ios changes to make app work with new react native version (#166)
0a227a0 
* feat: add back the splash screen

* ios folder changes in configuration

* chore: new permission package for handling camera permission and pager view for tab view control

* fix: padding top adjustment for new iPhone screens

* fix: placeholder line-break when editing

* docs: add patch comment

* docs: add TODO

Co-authored-by: André Carneiro <andreluizmrcarneiro@gmail.com>
@r4mmer
chore: linter changes
afd89e7
@r4mmer r4mmer merged commit 667a2c2 into dev May 17, 2022
@r4mmer r4mmer deleted the feat/upgrade-react-native branch May 17, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

@andreabadesso andreabadesso andreabadesso approved these changes

Assignees

@r4mmer r4mmer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r4mmer @pedroferreira1 @andreabadesso