Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine tune dark mode #8

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Fine tune dark mode #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/commander/controller/converters/AbstractImageConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ protected AbstractImageConverter(File in, File out, String format) {


/**
* Handle trans bg boolean.
* Handle transparent background conversion.
*
* @param srcImage the src image
* @param imgFormat the img format
Expand Down
5 changes: 2 additions & 3 deletions src/main/java/com/commander/controller/converters/ConvertibleFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,9 @@
import static org.apache.commons.io.FilenameUtils.EXTENSION_SEPARATOR_STR;

/**
* {@code ConvertibleFactory} is an utility class for creating {@code Convertible} objects
* to be passed on to ConvertUtils for conversions.
* {@code ConvertibleFactory} is an utility class for creating {@code Convertible} objects.
*
* @author HGDIV
* @author Harry Dulaney
*/
public class ConvertibleFactory {

Expand Down
7 changes: 2 additions & 5 deletions src/main/java/com/commander/controller/converters/ImageConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public class ImageConverter extends AbstractImageConverter {
*
* @param fileIn the in
* @param fileOut the out
* @param format the output format
* @param format the output format
*/
public ImageConverter(File fileIn, File fileOut, String format) {
super(fileIn, fileOut);
Expand All @@ -40,7 +40,7 @@ private boolean genericConversion() {
BufferedImage sourceImage = ImageIO.read(in);
if (sourceImage.getTransparency() != BufferedImage.OPAQUE) {
if ((FilenameUtils.getExtension(in.getName())).equals(DocType.GIF_ID) && !(format.equalsIgnoreCase(DocType.PNG_ID))) {
result = handleTransBg(sourceImage,format,out);
result = handleTransBg(sourceImage, format, out);

} else {
try {
Expand Down Expand Up @@ -79,11 +79,8 @@ private boolean genericConversion() {
@Override
public void convert() {


boolean succeeded = genericConversion();



if (succeeded) {
deleteSourceFile(true, in);
DialogHelper.showInfoAlert("Success! Your image named: " + in.getName() + " was converted to: " + out.getName() +
Expand Down
1 change: 0 additions & 1 deletion src/main/java/com/commander/controller/converters/PngConversions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ public PngConversions(File fileIn, File fileOut, String format) {

@Override
public void convert() {
// TODO: USE THE PNGDECODER to rework these methods
final long starttime = System.currentTimeMillis();
/* Handle PNG to JPG*/
if (format.equalsIgnoreCase(DocType.JPG_ID)) {
Expand Down
4 changes: 0 additions & 4 deletions src/main/resources/style/dark.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,25 +6,21 @@
@font-face {
font-family: TitilliumWeb;
src: url('fonts/TitilliumWeb-Italic.ttf');
font-style: italic;
}

@font-face {
font-family: TitilliumWeb;
src: url('fonts/TitilliumWeb-Bold.ttf');
font-weight: bold;
}

@font-face {
font-family: TitilliumWeb;
src: url('fonts/TitilliumWeb-Black.ttf');
font-stretch: expanded;
}

@font-face {
font-family: TitilliumWeb;
src: url('fonts/TitilliumWeb-Light.ttf');
font-style: light;
}

.root {
Expand Down
4 changes: 0 additions & 4 deletions src/main/resources/style/light.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,25 +6,21 @@
@font-face {
font-family: TitilliumWeb;
src: url('fonts/TitilliumWeb-Italic.ttf');
font-style: italic;
}

@font-face {
font-family: TitilliumWeb;
src: url('fonts/TitilliumWeb-Bold.ttf');
font-weight: bold;
}

@font-face {
font-family: TitilliumWeb;
src: url('fonts/TitilliumWeb-Black.ttf');
font-stretch: expanded;
}

@font-face {
font-family: TitilliumWeb;
src: url('fonts/TitilliumWeb-Light.ttf');
font-style: light;
}

.root {
Expand Down