-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unlock locked interior doors with overworld keys enabled #4948
Unlock locked interior doors with overworld keys enabled #4948
Conversation
Unfortunately, you also should go back through all of the logic and remove the key from the inside condition as well |
Oh oops, yeah you're right. Should we commit to remove the code instead of having to comment it out everywhere then? |
Will we ever want these to return? If not probably best to nix them |
I mean, I couldn't figure out a reason we'd want to have them still available. Doesn't mean someone won't. But, I guess if someone really needs it later (if more than 3 of us can't think of anything, it's probably pretty unlikely in the future), we can point them back to this PR for what they used to be. I've changed my mind and say nix them. |
finally a PR that enforces the hyrule fire code |
Interior door logic removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The connections should not be removed. The conditions should be changed to true
, but still left there.
... uhh yeah you're totally right. Not even sure why I thought I had to remove them outright. |
Done, hopefully this time without making silly mistakes 🦘 |
Resolves #4994 |
Yeah that's a mouthful. After feedback from people playing with the overworld keys and entrance rando, we decided to not lock the doors from the inside. I commented them out if this decision needs revisiting in the future, maybe if there turns out to be a demand to turn this on anyway etc.
Build Artifacts