Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlock locked interior doors with overworld keys enabled #4948

Merged

Conversation

aMannus
Copy link
Contributor

@aMannus aMannus commented Jan 24, 2025

Yeah that's a mouthful. After feedback from people playing with the overworld keys and entrance rando, we decided to not lock the doors from the inside. I commented them out if this decision needs revisiting in the future, maybe if there turns out to be a demand to turn this on anyway etc.

Build Artifacts

@garrettjoecox
Copy link
Contributor

Unfortunately, you also should go back through all of the logic and remove the key from the inside condition as well

@aMannus
Copy link
Contributor Author

aMannus commented Jan 24, 2025

Oh oops, yeah you're right. Should we commit to remove the code instead of having to comment it out everywhere then?

@garrettjoecox
Copy link
Contributor

Will we ever want these to return? If not probably best to nix them

@aMannus aMannus marked this pull request as draft January 24, 2025 19:01
@Malkierian
Copy link
Contributor

I mean, I couldn't figure out a reason we'd want to have them still available. Doesn't mean someone won't. But, I guess if someone really needs it later (if more than 3 of us can't think of anything, it's probably pretty unlikely in the future), we can point them back to this PR for what they used to be. I've changed my mind and say nix them.

@briaguya-ai
Copy link
Contributor

finally a PR that enforces the hyrule fire code

@aMannus aMannus marked this pull request as ready for review January 30, 2025 09:58
@aMannus
Copy link
Contributor Author

aMannus commented Jan 30, 2025

Interior door logic removed

@aMannus aMannus added this to the 9.0.0 milestone Jan 30, 2025
Copy link
Contributor

@Pepe20129 Pepe20129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The connections should not be removed. The conditions should be changed to true, but still left there.

@aMannus
Copy link
Contributor Author

aMannus commented Jan 30, 2025

... uhh yeah you're totally right. Not even sure why I thought I had to remove them outright.

@aMannus
Copy link
Contributor Author

aMannus commented Feb 3, 2025

Done, hopefully this time without making silly mistakes 🦘

@aMannus
Copy link
Contributor Author

aMannus commented Feb 4, 2025

Resolves #4994

@aMannus aMannus merged commit b2cb3ff into HarbourMasters:develop Feb 4, 2025
5 checks passed
@aMannus aMannus deleted the unlock-interior-interior-doors branch February 4, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants