fix tooltip wonkyness

[briaguya-ai]

@Spodi mentioned

oh what, my game just blacked out. no image at all
hovering over some option in Graphic enhancement menu causes that
let me check which one
seems like cull glitch actors, when it is actually disabled (as in: greyed out) (edited)
hovering ANY grayed out menu checkbox results in a blackout, lol
nothing i tried makes it go away, other than completely closing the game (edited)

i did some digging and wasn't able to repro that exact behavior but following the repro steps led to

wonk.mp4

i then found/mentioned

so it seems to be tooltip related, i can't repro the issue if i comment out

Shipwright/soh/soh/UIWidgets.cpp

Lines 218 to 220 in 0ae7f62

	if (ImGui::IsItemHovered(ImGuiHoveredFlags_AllowWhenDisabled) && strcmp(disabledTooltipText, "") != 0) {
	ImGui::SetTooltip("%s", disabledTooltipText);
	}

(which is interesting because it's not something i touched in #4838)

after more digging i found

so the tooltip stuff has something to do with ocornut/imgui@f953ebf

i tried commenting out BeginDisabledOverrideReenable and EndDisabledOverrideReenable and it doesn't bug out, but i see the standard tooltip instead of the disabled tooltip

i can also get to that point without changing imgui source by changing ReEnableComponent to have the tooltip stuff before PopStyleVar and PopItemFlag instead of in between them (and i know we're making it into the if block because i put logging in there and it's logging when i'm hovering

orig

    void ReEnableComponent(const char* disabledTooltipText) {
        // End of disable region of previous component
        ImGui::PopStyleVar(1);
        if (ImGui::IsItemHovered(ImGuiHoveredFlags_AllowWhenDisabled) && strcmp(disabledTooltipText, "") != 0) {
            ImGui::SetTooltip("%s", disabledTooltipText);
        }
        ImGui::PopItemFlag();
    }

shows non-disabled tooltip

    void ReEnableComponent(const char* disabledTooltipText) {
        // End of disable region of previous component
        if (ImGui::IsItemHovered(ImGuiHoveredFlags_AllowWhenDisabled) && strcmp(disabledTooltipText, "") != 0) {
            SPDLOG_INFO("blarg");
            ImGui::SetTooltip("%s", disabledTooltipText);
        }
        ImGui::PopStyleVar(1);
        ImGui::PopItemFlag();
    }

so i did a bit more digging and grabbed a build from before the imgui bump https://github.com/HarbourMasters/Shipwright/actions/runs/12721871572 and tested out the tooltip - it seems we're seeing the standard (non-disabled) tooltip every time (even when the checkbox is disabled) there too

Build Artifacts

• soh-windows.zip
• soh-linux.zip
• soh-mac.zip