rando: vanilla dungeon rewards #4836
Conversation
|
Merged in latest to test, it seems to not be properly placing the light medallion, causing generation failure with 6 med bridge. |
will have time to look into later next week if I can't find time this weekend |
|
Issue was that location_access.cpp listed Link's Pocket instead of Gift From Rauru in dungeonRewardLocations Gift from Rauru is the correct choice: it's the location with light medallion as it's vanilla reward. There's some talk about getting rid of Link's Pocket. Let's start by ignoring Link's Pocket for dungeon rewards being at the end of dungeons Other choice was to remove both gift & pocket from dungeonRewardLocations, adding explicit logic everywhere dungeonRewardLocations is referenced in order to use pocket for non-vanilla options & gift for vanilla options |
serprex
force-pushed
the
rando-vanilla-dungeon-rewards
branch
from
a356b3d to
37b54be
Compare
| @@ -182,6 +182,7 @@ void Context::ItemReset() { | |||
| GetItemLocation(il)->ResetVariables(); | |||
| } | |||
|
|
|||
| GetItemLocation(RC_GIFT_FROM_RAURU)->ResetVariables(); | |||
There was a problem hiding this comment.
Little confused here why allLocations isn't sufficient enough to not loop over dungeonRewardLocations at all here
There was a problem hiding this comment.
It works perfectly fine from my testing.
I also think that Link's Pocket should be removed as that's just a carryover multiple times over at this point, it does mean that you will no longer see a dungeon reward in the file before the first load but imo, that's irrelevant.
serprex
force-pushed
the
rando-vanilla-dungeon-rewards
branch
from
08cb5b8 to
f00c142
Compare
|
I'm taking a break due to burnout until 9.0 release. |
fixes #4671
exists already in ootr. becomes more useful with ootr's option to have compass tell boss reward, which a future update could add
Build Artifacts