Resolve Check Tracker filter performance issues #4111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop passing checksByArea to functions in the same namespace. Only get value of `HideFilteredAreas` once per frame. Gate area and check evaluations behind checks being visible and search filter size greater than 0. Proper function capitalization.
garrettjoecox
approved these changes
May 6, 2024
|
Not really sure what change this is conflicting with, but once you fix I'll merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the check filter got added, there were quite a few problems with redundant checks, unnecessary checking, etc, causing massive lag with the check tracker open. The worst of these was passing
checksByAreatoshouldHideArea()for every area every frame, probably creating a copy every time. SincechecksByAreais a global variable in theCheckTrackernamespace, this passing was unnecessary anyway. PassingcheckSearchwas also unnecessary for the same reason.Also properly capitalized the function names for it, and put
IsVisibleInCheckTracker()into the newly renamedShouldShowCheck()that also checks for filter matching, if applicable.Build Artifacts