Account for removed object dependency in Deku Scrub Leader #3878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inspectredc
approved these changes
Jan 24, 2024
Archez
approved these changes
Jan 31, 2024
|
Force-pushed to rebase on develop-macready |
garrettjoecox
approved these changes
Feb 2, 2024
briaguya-ai
approved these changes
Feb 2, 2024
garrettjoecox
merged commit bb1078e
into
HarbourMasters:develop-macready
8 checks passed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #161
When an actor is spawned as a child, it is spawned, and then the parent and child pointers are set. In the Deku Scrub Leader's
Init, it stores its parent to a new pointer and uses that pointer to signal to other actors. If the parent is set afterInit, how does this work?Well, that is because
Initis not called until the actor's object dependency is loaded. Because we completely ignore that (all object are treated as loaded all the time),Initis always ran right as an actor is spawned.To account for this behavior, I have added a second attempt to store the parent in leader's action function immediately following load.
Note that in the vanilla game, the original behavior is actually a bug. Theoretically, the object could be loaded on frame 1. This is almost certainly never going to happen in practice, however.
Build Artifacts