Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item Tracker Hookshot/Longshot Identifiers #3848

Merged

Conversation

Patrick12115
Copy link
Contributor

@Patrick12115 Patrick12115 commented Jan 12, 2024

Adds an H and L for Hookshot and Longshot to be able to tell more clearly which one you have, since the icons are very similar.

image
image

2024-01-12.00-19-16.mp4

Build Artifacts

Adds an H and L for Hookshot and Longshot to be able to tell more clearly which one you have.
@Pepe20129
Copy link
Contributor

I think this should be an option as some people (specially those playing with mods that make the textures less similar) might prefer to not have this enabled.

@Patrick12115
Copy link
Contributor Author

I think this should be an option as some people (specially those playing with mods that make the textures less similar) might prefer to not have this enabled.

I can do that

Adds a toggle if players don't want it on. Also scales the letter to stay constant with the icons, both size and position. Also now hides the letter if you don't have a hookshot yet.
@Patrick12115
Copy link
Contributor Author

I think this should be an option as some people (specially those playing with mods that make the textures less similar) might prefer to not have this enabled.

I can do that

Added a toggle if players don't want it on. Also now scales the letter to stay constant with the icons, both size and position and now hides the letter if you don't have a hookshot yet.

@PurpleHato
Copy link
Member

Great addition!
I just have a small suggestion regarding the placement of the text. I believe it would be more consistent if it followed the same logic as the ammo in terms of positioning. Currently, it's not at the same height, and if the option is toggled, you might also want to adjust its alignment to the left when necessary.

@Patrick12115
Copy link
Contributor Author

Great addition!

I just have a small suggestion regarding the placement of the text. I believe it would be more consistent if it followed the same logic as the ammo in terms of positioning. Currently, it's not at the same height, and if the option is toggled, you might also want to adjust its alignment to the left when necessary.

Moving it to where it was was a personal choice for 2 reasons. One to follow how the other trackers out there do it, for familiarity, and two because the text grows with the icon and if it was below, it would start going into the icon below, which does not look good. Also no idea what you mean by move the alignment to the left.

@garrettjoecox garrettjoecox merged commit c49908c into HarbourMasters:develop Feb 2, 2024
8 checks passed
@Patrick12115 Patrick12115 deleted the Hookshot-Item-Tracker branch October 1, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants