Fix: Alt backgrounds and some models not always loading after toggling alt mode

[Archez]

There was an issue where if you ever loaded the non-alt version of a pre-rendered background, you wouldn't be able to load the non-alt version for the rest of the session.

This stems from the way that we handle caching and looking up resources. The way the resource manager works when requesting a resource is that we first check to see if we have a cached alt version, if we don't we then check to see if we have a cached non-alt version, if we do that gets returned, otherwise the normal resource load flow is performed.

The way alt textures are actually loaded is via Fast3D by direct calls to LoadResourceProcess which bypasses the cache lookup. However, rooms with pre-rendered backgrounds first attempt to load the resource to check if its a "background" type to see if we need to decrypt the original jpeg. This check for the background type will end up returning the cached non-alt version since alt resources are cleared from cache on scene change.

As a mitigation for now, I have added a few helper methods to force "unload" the non-alt background resource so that no cache is returned on the lookup, allowing the alt version to successfully be returned.

In the long run, we may need to reconsider the caching lookup as it may be affecting other areas in the code.

---

I have applied the above unloading pattern to ResourceMgr_LoadGfxByName to address some alt models not loading after the non-alt version has loaded once. Closes #3076 and #3078.

Build Artifacts

• soh.otr.zip
• soh-linux-compatibility.zip
• soh-linux-performance.zip
• soh-mac.zip
• soh-switch.zip
• soh-wiiu.zip
• soh-windows.zip

[Archez]

The cache quirk described above may be the cause of #3078 and #3076, so a similar fix may address those, or improving/changing the cache behavior may be necessary overall to handle all the edge cases.

[Archez]

I've included the same "unload" pattern to apply for DLs loaded in code which address most (if not all) of the known alt toggle issues pertaining to links equipment and various models.

I don't know of other instances where cached values are bypassing alt look ups, so I'd like to limit this unload pattern until we can improve the asset loading process.

[briaguya-ai]

merged in via #3434