Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the final Magic Bean cost 99 rupees in randomiser when it is not shuffled #3392

Merged
merged 3 commits into from
Feb 16, 2024

Conversation

Pepper0ni
Copy link
Contributor

@Pepper0ni Pepper0ni commented Nov 13, 2023

This change fixes a logical oversight where the game did not account for the final magic bean costing 100 rupees and thus requiring a wallet. This oversight could potentially result in a soflocked glitchless seed in the case of a bean-locked wallet. As players do not typically plant 9 magic beans, logic is left alone and instead the bean salesman sells the last bean for 1 Rupee cheaper. This is handled the same way on N64.

For copyright rules, a whole new line of text is provided.

Note that this PR still needs a French translation, which I have already requested and am waiting for.

Build Artifacts

@briaguya-ai
Copy link
Contributor

would you mind splitting the text id stuff out into a separate PR?

@Pepper0ni
Copy link
Contributor Author

I have some IRL priorities ATM and if I do it will conflict with itself. If that's OK I can get to it when I can.

@Pepper0ni Pepper0ni changed the title Make the final Magic Bean cost 99 rupees in randomiser when it is not shuffled, and clean up Text IDs Make the final Magic Bean cost 99 rupees in randomiser when it is not shuffled Dec 3, 2023
@Pepper0ni
Copy link
Contributor Author

Removed the text ID stuff, but Am still waiting on a french translation from @PurpleHato before this is ready for live

@PurpleHato
Copy link
Member

Removed the text ID stuff, but Am still waiting on a french translation from @PurpleHato before this is ready for live

Je te vends mon dernier %rHaricot&magique%w pour %r99 Rubis%w.\x1B&%gAcheter&Ne pas acheter%w

Co-authored-by: Purple Hato <linkvssangoku.jr@gmail.com>
Copy link
Contributor

@garrettjoecox garrettjoecox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you intend on porting this to v3? Or is it already in v3?

@Pepper0ni
Copy link
Contributor Author

Do you intend on porting this to v3? Or is it already in v3?

It's not in V3 yet, I'm currently coming back from a break and catching up on what state v3 is in and figuring out my next goal, which could be this if people think it needs porting to v3 ahead of develop merges.

@garrettjoecox garrettjoecox merged commit 0932e1e into HarbourMasters:develop Feb 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants