-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the final Magic Bean cost 99 rupees in randomiser when it is not shuffled #3392
Conversation
would you mind splitting the text id stuff out into a separate PR? |
I have some IRL priorities ATM and if I do it will conflict with itself. If that's OK I can get to it when I can. |
Removed the text ID stuff, but Am still waiting on a french translation from @PurpleHato before this is ready for live |
|
Co-authored-by: Purple Hato <linkvssangoku.jr@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you intend on porting this to v3? Or is it already in v3?
It's not in V3 yet, I'm currently coming back from a break and catching up on what state v3 is in and figuring out my next goal, which could be this if people think it needs porting to v3 ahead of develop merges. |
This change fixes a logical oversight where the game did not account for the final magic bean costing 100 rupees and thus requiring a wallet. This oversight could potentially result in a soflocked glitchless seed in the case of a bean-locked wallet. As players do not typically plant 9 magic beans, logic is left alone and instead the bean salesman sells the last bean for 1 Rupee cheaper. This is handled the same way on N64.
For copyright rules, a whole new line of text is provided.
Note that this PR still needs a French translation, which I have already requested and am waiting for.
Build Artifacts