Use manifest for windows DPI awareness #3270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spodi
force-pushed
the
win-dpi-aware
branch
2 times, most recently
from
315a016 to
5229173
Compare
Spodi
force-pushed
the
win-dpi-aware
branch
2 times, most recently
from
6c8445a to
216d3d4
Compare
inspectredc
approved these changes
Feb 1, 2024
Spodi
force-pushed
the
win-dpi-aware
branch
2 times, most recently
from
e76db3c to
7cbef2d
Compare
|
Removed LUS changes in this PR, cause they are already pulled in the SoH dev branch. Keep in mind this is kinda urgent now that the LUS stuff is in. Without this there is no DPI awareness at all on Windows. This means the game (including imgui) would run at the wrong internal resolution if Dpi are set >100%. |
briaguya-ai
approved these changes
Feb 11, 2024
garrettjoecox
approved these changes
Feb 12, 2024
Spodi
added a commit
to Spodi/Shipwright
that referenced
this pull request
Jul 27, 2024
Archez
pushed a commit
that referenced
this pull request
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for proper DPI awareness on Windows.
The LUS PR pushes the responsibility of making the Windows app DPI aware to the port, so we need this change to the Windows app manifest on the ports side, to tell Windows that we can handle it.
This means when the LUS changes are merged, the port is completely DPI unaware under Windows until the app manifest changes in this PR are merged!
Build Artifacts